Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing category bar on mobile #108

Open
georgeteo opened this issue Oct 29, 2015 · 13 comments
Open

Changing category bar on mobile #108

georgeteo opened this issue Oct 29, 2015 · 13 comments

Comments

@georgeteo
Copy link
Contributor

No description provided.

@fatlotus
Copy link
Member

Wait! This is still broken methinks

@georgeteo
Copy link
Contributor Author

Oops. What was the issue here again?

@georgeteo georgeteo reopened this Nov 15, 2015
@fatlotus
Copy link
Member

screen shot 2015-11-15 at 12 45 34 pm

screen shot 2015-11-15 at 12 45 38 pm

@fatlotus
Copy link
Member

turns out it's only mostly responsive

tumblr_loww57mhwi1qasdqt

@georgeteo
Copy link
Contributor Author

Issue is the category bar or the padding aroudn "new listing, ..."?

@fatlotus
Copy link
Member

I guess both... the whole thing has some wonk.
dammit

@georgeteo
Copy link
Contributor Author

Padding is my bad.

Thoughts on a good way of dealing with category overflow when the width of the page is not quite short enough to do to the full mobile view?

Some thoughts:

  1. Truncate category names
  2. Do the mobile view earlier
  3. Two rows

@fatlotus
Copy link
Member

Yeah, I honestly don't know. The mobile view is already a little weird — so maybe (3)? But then we'd have three regimes rather than just two.

@tranv94
Copy link
Contributor

tranv94 commented Nov 30, 2015

Thoughts on using a dropdown menu, like amazon's, for desktop?

screen shot 2015-11-30 at 1 37 39 am

And for mobile, maybe a dedicated page for categories via button?

@georgeteo
Copy link
Contributor Author

Yeah I was thinking like a sidebar that comes out when a button is pressed. Was going to do it as part of the polymer migration when I have some time. (Thinking winter break)

@tranv94
Copy link
Contributor

tranv94 commented Dec 10, 2015

I'm on winter break now with a surplus of free time, are you working on a separate repository for the polymer integration? I would love to help :)

@fatlotus
Copy link
Member

Right now, I'm focused mostly on switching backends (see PR), but that's definitely something we're considering! Talk to @georgeteo

@georgeteo
Copy link
Contributor Author

@tranv94: Hi! Let's chat if you're still interested in fiddling around with front end changes. We're thinking react + semantic UI. (I've FB messaged you.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants