Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate notifications for game and tournament #301

Open
ishiii-s opened this issue Nov 27, 2023 · 4 comments · May be fixed by #383
Open

Integrate notifications for game and tournament #301

ishiii-s opened this issue Nov 27, 2023 · 4 comments · May be fixed by #383
Assignees
@ishiii-s @henrietta-k @AndrewM131
Labels
x/user-profiles-friending
Milestone
2023/Sprint 3

Comments

@ishiii-s
Copy link
Contributor

ishiii-s commented Nov 27, 2023 •
edited

Description: This issue will address integrating notifications into previous functionality of allowing friends to invite other people to games and tournaments (handled by issue #194)
@ishiii-s ishiii-s self-assigned this Nov 27, 2023
@AndrewM131 AndrewM131 added this to the 2023/Sprint 3 milestone Nov 30, 2023
@AndrewM131
Copy link
Contributor

Description: In this issue, we will integrate notifications for games and tournaments based on the notification model created, and will work similarly as it does for other notifications, such as friending.

@ishiii-s ishiii-s linked a pull request Dec 2, 2023 that will close this issue
Open
@AndrewM131 AndrewM131 linked a pull request Dec 3, 2023 that will close this issue
Integrate Notifications Into Game and Tournament Invites #383
Open
@ishiii-s
Copy link
Contributor Author

ishiii-s commented Dec 5, 2023

Update: We met in person on Sunday Dec 4 to discuss and address this issue.

@ishiii-s
Copy link
Contributor Author

ishiii-s commented Dec 5, 2023

Update: First PR was made and first review (and requested changes) have also been made. I've offered some clarification on the goals of the PR in response to these requested changes.

@ishiii-s
Copy link
Contributor Author

ishiii-s commented Dec 6, 2023

Update: This issue was not ultimately able to be resolved as the code that was written was not able to be reviewed in time to be merged with dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ishiii-s ishiii-s

@henrietta-k henrietta-k

@AndrewM131 AndrewM131

Labels
x/user-profiles-friending
Projects
CMSC 22000 Scrum Board
Status: In Progress
Milestone
2023/Sprint 3
Development

Successfully merging a pull request may close this issue.

Integrate Notifications Into Game and Tournament Invites uchicago-cs/chigame
3 participants
@ishiii-s @henrietta-k @AndrewM131