Add guardrails against transparent background color #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmols
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #908
Note: These changes solve this issue independent of the corresponding changes made to phpally in this pull request.
Issue:
As of recent, UCF instructional designers have been complaining about a bug that flags HTML elements with the
background-color: transparentstyle as having insufficient contrast with their background. A pull request was recently made to address this particular issue in phpally, making any elements with the transparent style inherit the background color of their parent element. The changes in the phpally pull request successfully got rid of the false positives, however, they could not address the scenario where there might actually be some color contrast issues. This is where this pull request comes in.Solution:
To address this issue, the changes made in this pull request will at first scan the HTML of any canvas page to look for any elements with the
background-color: transparentstyle. If such elements are found, then UDOIT will change the HTML elements to inherit the background color of their parent element, which allows the user to change the true background color of the elements, and resolve any contrast issues resulting from them.