Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase test coverage of loaders #2034

Open
JackMorganNZ opened this issue Nov 2, 2022 · 1 comment
Open

Increase test coverage of loaders #2034

JackMorganNZ opened this issue Nov 2, 2022 · 1 comment
Assignees
@Yamboy1
Labels
backend Related to the software powering the website testing urgent

Comments

@JackMorganNZ
Copy link
Member

Changes to the loaders were required urgently and tests have not been added to the new code yet.
New tests should be added urgently to check the new lines.
@JackMorganNZ JackMorganNZ added testing backend Related to the software powering the website urgent labels Nov 2, 2022
@JackMorganNZ JackMorganNZ mentioned this issue Nov 2, 2022
Merged
@Yamboy1 Yamboy1 mentioned this issue Nov 30, 2022
Closed
@Yamboy1 Yamboy1 self-assigned this Nov 30, 2022
@Yamboy1
Copy link
Contributor

Yamboy1 commented Nov 30, 2022 •
edited

See 7f9874b. These changes will cause problems when content is added or removed from the middle using loaders, additionally, content being removed from the end will not be removed. See uccser/cs-field-guide#2023 for a similar fix in field guide.

@Yamboy1 Yamboy1 mentioned this issue Dec 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yamboy1 Yamboy1

Labels
backend Related to the software powering the website testing urgent
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JackMorganNZ @Yamboy1