Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using production resource generators in test suite #1044

Open
JackMorganNZ opened this issue Sep 5, 2018 · 0 comments · May be fixed by #1423
Open

Avoid using production resource generators in test suite #1044

JackMorganNZ opened this issue Sep 5, 2018 · 0 comments · May be fixed by #1423
Assignees
@courtneycb
Labels
project style testing

Comments

@JackMorganNZ
Copy link
Member

Currently generators such as Grid are used in tests that aren't directly related to the Grid resource. These will break if Grid is changed, and so should use the BareResource generator class available in the test suite. This bare resource generator needs to be mocked as an import into the csunplugged/resources/generators/__init__.py file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@courtneycb courtneycb

Labels
project style testing
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use BareResourceGenerator in test suite. uccser/cs-unplugged
2 participants
@JackMorganNZ @courtneycb