Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm i fails after cloning the repo #100

Open
jeffgca opened this issue May 30, 2023 · 1 comment
Open

npm i fails after cloning the repo #100

jeffgca opened this issue May 30, 2023 · 1 comment

Comments

@jeffgca
Copy link
Contributor

jeffgca commented May 30, 2023

Steps:

  1. git clone git@github.com:ucan-wg/ts-ucan.git
  2. cd ts-ucan
  3. npm i

It looks like this repo could use a 'Contributing' block in the README that specifies the basics of how to check out the repo and work with it.

The error I got using npm:

npm WARN deprecated w3c-hr-time@1.0.2: Use your platform's native performance.now() and performance.timeOrigin.
npm ERR! code 2
npm ERR! path /Users/jeff/code/fission/hacks/ts-ucan/packages/default-plugins
npm ERR! command failed
npm ERR! command sh -c yarn build
npm ERR! yarn run v1.22.19
npm ERR! $ rimraf dist
npm ERR! $ yarn run dist
npm ERR! $ yarn run dist:prep && yarn run dist:src && yarn run dist:cjs && yarn run dist:esm && yarn run dist:types && yarn run dist:pkg
npm ERR! $ copyfiles --error tsconfig.json ./dist/
npm ERR! $ copyfiles --error --up 1 "./src/**/*" ./dist/src/
npm ERR! $ tsc --project ./dist/ --module commonjs --outDir ./dist/cjs/ --sourceMap
npm ERR! dist/src/default-plugins.ts(1,25): error TS2307: Cannot find module '@ucans/core' or its corresponding type declarations.
npm ERR! dist/src/ed25519/keypair.ts(5,54): error TS2307: Cannot find module '@ucans/core' or its corresponding type declarations.
npm ERR! dist/src/ed25519/plugin.ts(1,30): error TS2307: Cannot find module '@ucans/core' or its corresponding type declarations.
npm ERR! dist/src/p256/keypair.ts(3,54): error TS2307: Cannot find module '@ucans/core' or its corresponding type declarations.
npm ERR! dist/src/p256/plugin.ts(1,30): error TS2307: Cannot find module '@ucans/core' or its corresponding type declarations.
npm ERR! dist/src/rsa/keypair.ts(6,54): error TS2307: Cannot find module '@ucans/core' or its corresponding type declarations.
npm ERR! dist/src/rsa/plugin.ts(1,30): error TS2307: Cannot find module '@ucans/core' or its corresponding type declarations.
npm ERR! info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
npm ERR! info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
npm ERR! info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
npm ERR! error Command failed with exit code 2.
npm ERR! error Command failed with exit code 2.
npm ERR! error Command failed with exit code 2.

Running yarn only produced a few warnings on the other hand:

yarn install v1.22.19
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
warning Lockfile has incorrect entry for "@ucans/default-plugins@*". Ignoring it.
[3/5] 🚚  Fetching packages...
[4/5] 🔗  Linking dependencies...
warning " > ts-node@10.9.1" has unmet peer dependency "@types/node@*".
warning " > ts-node@10.9.1" has unmet peer dependency "typescript@>=2.7".
[5/5] 🔨  Building fresh packages...
✨  Done in 3.73s.
@dholms
Copy link
Collaborator

dholms commented May 30, 2023

ah yeah it uses yarn workspaces for the monorepo

i think npm has support for something similar now 🤔

matheus23 added a commit that referenced this issue May 31, 2023
* Added the beginnings of a contrbution block that includes instructions to use yarn, as per #100

* Typos

Signed-off-by: Philipp Krüger <philipp.krueger1@gmail.com>

---------

Signed-off-by: Philipp Krüger <philipp.krueger1@gmail.com>
Co-authored-by: Philipp Krüger <philipp.krueger1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants