Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we make proofs into IPLD native links #137

Open
Gozala opened this issue Dec 8, 2022 · 1 comment
Open

Should we make proofs into IPLD native links #137

Gozala opened this issue Dec 8, 2022 · 1 comment

Comments

@Gozala
Copy link
Contributor

Gozala commented Dec 8, 2022

This is something that comes up every now and then on our side, the fact that that prf are just strings that are serialized CIDs

spec/README.md

Line 355 in 692e8aa

| `prf` | `String[]` | Proof of delegation (hash-linked UCANs) | No |

Implies that we have to do pre / post processing to map those back into CIDs. It is really tempting to just follow the DAG-JSON spec to encode them as links instead https://ipld.io/specs/codecs/dag-json/spec/#links which also specifies exact base encoding that helps with hash consistency

This is not critical and has some size costs associated, but it came enough times that I thought it might be worth surfacing

@expede
Copy link
Member

expede commented Mar 20, 2023

Do you mean wrapping them in {"/": CID}? I think that's a surprising format for people not working in native IPFD, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants