Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit null to omit subject (powerline) #11

Open
expede opened this issue Feb 27, 2024 · 1 comment
Open

Explicit null to omit subject (powerline) #11

expede opened this issue Feb 27, 2024 · 1 comment

Comments

@expede
Copy link
Member

expede commented Feb 27, 2024

I chatted with @matheus23 earlier today about the updated powerline syntax & changes from past iterations. [Philipp, feel free to correct me if I'm wrong on any of the below but wanted to capture here.]

TL;DR he's in favour, but raised that it's too easy to omit the sub field accidentally. Two suggestions:

  1. Require that you use an explicit sub: null if omitted
  2. Use a glob sub: "did:*

The glob has the disadvantage that it looks like you can restrict DIDs by scheme (did:dns:*), when I'm pretty sure that's not the behaviour that we want.

I am in favour of making the Null explicit. In most libraries you're already going to have to give have some variation on audience: Option<DID>, so let's just render None to null as a default.

Any objections?

@expede expede changed the title Powerline optional subject synatx Explicit null to omit subject (powerline) Feb 27, 2024
@Gozala
Copy link

Gozala commented Feb 29, 2024

It seems consistent with exp so sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants