Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore(CI): builds should succeed in self-contained PR builds #110

Open
bsherman opened this issue May 31, 2023 · 1 comment
Open

Chore(CI): builds should succeed in self-contained PR builds #110

bsherman opened this issue May 31, 2023 · 1 comment

Comments

@bsherman
Copy link
Contributor

When nvidia builds run in a PR, they fail because after building the akmods image, that is not published, thus the follow on builds fail because they attempt to reference the just built image with that PR tag.

Need a solution to this which allows valid builds but doesn't allow signing/publishing of images in PRs.

@castrojo
Copy link
Member

castrojo commented Jun 6, 2023

cc @marcoceppi

We've used "if in a PR skip this" things in sections before in bluefin but I forgot what to search for. Nevermind, we have those in this repo already, sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants