New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update following-up for the assigneer #863

Open

wannacfuture opened this issue Oct 17, 2023 · 0 comments

Contributor

wannacfuture commented Oct 17, 2023 •

edited

Currently we check the last commit date and comment of the assigneer on the linked PR to include them to last activity time of the assigneer.

While investigating the codebase, I just realized that wrong function is being used to get the linked PR.
https://github.com/ubiquity/ubiquibot/blob/3ad77e54a0202e442bdc7e2973326e8a7a32b74a/src/handlers/wildcard/unassign.ts#L113C35-L113C66

Also, it checks any linked PR without checking if the PR's author is assigneer.

We need to replace getOpenedPullRequestsForAnIssue function with gitLinkedPrParser.
Also, we need to check the last commit date and comment only for the assigneer's PR.

The text was updated successfully, but these errors were encountered:

wannacfuture changed the title ~~Update follow-up for the assigneer for an issue~~ Update following-up for the assigneer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment