Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Share Strings #837

Open
0x4007 opened this issue Sep 25, 2023 · 25 comments · May be fixed by #862
Open

Tests: Share Strings #837

0x4007 opened this issue Sep 25, 2023 · 25 comments · May be fixed by #862

Comments

@0x4007
Copy link
Member

0x4007 commented Sep 25, 2023

          Do you think it's feasible that we export and use the exact same strings from the code base?

Originally posted by @pavlovcik in #640 (comment)

@Sadaf-A
Copy link
Contributor

Sadaf-A commented Sep 25, 2023

@pavlovcik I do see an issue with that when we want to change something later it will have to be changed everywhere. Why not store string constants in a single file and export the string from there instead of copying the whole string.However, interpolation may not work when we export string it may be treated as a plain string.We can use something like

export function myString(varValue: string): string { return `Value of var is: ${varValue}`; }

this to resolve that
I hope this is the issue you were addressing to.

@abhinandanmishra1
Copy link

/start

@ubiquibot
Copy link

ubiquibot bot commented Sep 26, 2023

Deadline Tue, 26 Sep 2023 16:52:45 UTC
Registered Wallet Please set your wallet address to use `/wallet 0x0000...0000`
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address @user.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the bounty.

    @ubiquibot
    Copy link

    ubiquibot bot commented Oct 1, 2023

    Do you have any updates @abhinandanmishra1? If you would like to release the bounty back to the DevPool, please comment /stop
    Last activity time: Tue Sep 26 2023 15:52:38 GMT+0000 (Coordinated Universal Time)

    @0x4007
    Copy link
    Member Author

    0x4007 commented Oct 1, 2023

    @pavlovcik I do see an issue with that when we want to change something later it will have to be changed everywhere. Why not store string constants in a single file and export the string from there instead of copying the whole string.However, interpolation may not work when we export string it may be treated as a plain string.We can use something like

    export function myString(varValue: string): string { return `Value of var is: ${varValue}`; }

    this to resolve that
    I hope this is the issue you were addressing to.

    It is not clear to me why you need a getter function to use the string. An export/import would do the job just the same

    @Sadaf-A
    Copy link
    Contributor

    Sadaf-A commented Oct 1, 2023

    @pavlovcik I do see an issue with that when we want to change something later it will have to be changed everywhere. Why not store string constants in a single file and export the string from there instead of copying the whole string.However, interpolation may not work when we export string it may be treated as a plain string.We can use something like

    export function myString(varValue: string): string { return `Value of var is: ${varValue}`; }

    this to resolve that
    I hope this is the issue you were addressing to.

    It is not clear to me why you need a getter function to use the string. An export/import would do the job just the same

    I did not know that if that is the case then it's even better

    @abhinandanmishra1
    Copy link

    /stop

    @ubiquibot
    Copy link

    ubiquibot bot commented Oct 1, 2023

    You have been unassigned from the bounty @abhinandanmishra1

    @Sadaf-A
    Copy link
    Contributor

    Sadaf-A commented Oct 1, 2023

    /start

    @ubiquibot
    Copy link

    ubiquibot bot commented Oct 1, 2023

    Deadline Sun, 01 Oct 2023 14:19:06 UTC
    Registered Wallet 0x0BEd00438D57d07E3667b85Fa8EB86Af147C7025
    Tips:
    • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address @user.
    • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
    • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the bounty.

      @ubiquibot
      Copy link

      ubiquibot bot commented Oct 5, 2023

      Do you have any updates @Sadaf-A? If you would like to release the bounty back to the DevPool, please comment /stop
      Last activity time: Sun Oct 01 2023 13:19:02 GMT+0000 (Coordinated Universal Time)

      @Sadaf-A
      Copy link
      Contributor

      Sadaf-A commented Oct 5, 2023

      Do you have any updates @Sadaf-A? If you would like to release the bounty back to the DevPool, please comment /stop Last activity time: Sun Oct 01 2023 13:19:02 GMT+0000 (Coordinated Universal Time)

      yes I will open a PR by tommorrow. I was busy with college

      @Sadaf-A
      Copy link
      Contributor

      Sadaf-A commented Oct 5, 2023

      @pavlovcik the file mentioned in the issue description does not exist anymore I'll try to find some other file where this is happening is you are aware of any such instances please let me know

      @Sadaf-A
      Copy link
      Contributor

      Sadaf-A commented Oct 5, 2023

      /stop

      @ubiquibot ubiquibot bot unassigned Sadaf-A Oct 5, 2023
      @ubiquibot
      Copy link

      ubiquibot bot commented Oct 5, 2023

      You have been unassigned from the bounty @Sadaf-A

      @Sadaf-A
      Copy link
      Contributor

      Sadaf-A commented Oct 5, 2023

      since, whilefoo is back I will complete the PRs being reviewed by him then get back to this

      @Keyrxng
      Copy link
      Contributor

      Keyrxng commented Oct 15, 2023

      /start

      @ubiquibot
      Copy link

      ubiquibot bot commented Oct 15, 2023

      Deadline Sun, 15 Oct 2023 12:14:59 UTC
      Registered Wallet 0xAe5D1F192013db889b1e2115A370aB133f359765
      Tips:
      • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address @user.
      • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
      • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the bounty.

        @Keyrxng Keyrxng linked a pull request Oct 15, 2023 that will close this issue
        @ubiquibot
        Copy link

        ubiquibot bot commented Oct 21, 2023

        Do you have any updates @Keyrxng? If you would like to release the bounty back to the DevPool, please comment /stop
        Last activity time: Tue Oct 17 2023 08:20:33 GMT+0000 (Coordinated Universal Time)

        @Keyrxng
        Copy link
        Contributor

        Keyrxng commented Oct 21, 2023

        awaiting response to latest comment on pr

        @ubiquibot
        Copy link

        ubiquibot bot commented Oct 25, 2023

        Do you have any updates @Keyrxng? If you would like to release the bounty back to the DevPool, please comment /stop
        Last activity time: Sat Oct 21 2023 23:28:38 GMT+0000 (Coordinated Universal Time)

        @Keyrxng
        Copy link
        Contributor

        Keyrxng commented Oct 25, 2023

        /stop

        @ubiquibot
        Copy link

        ubiquibot bot commented Oct 25, 2023

        Skipping /stop because it is disabled on this repo

        @ubiquibot
        Copy link

        ubiquibot bot commented Oct 30, 2023

        Do you have any updates @Keyrxng? If you would like to release the bounty back to the DevPool, please comment /stop
        Last activity time: Wed Oct 25 2023 23:46:28 GMT+0000 (Coordinated Universal Time)

        Copy link

        ubiquibot bot commented Nov 6, 2023

        Do you have any updates @Keyrxng? If you would like to release the bounty back to the DevPool, please comment /stop
        Last activity time: Wed Nov 01 2023 14:32:13 GMT+0000 (Coordinated Universal Time)

        Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
        Projects
        None yet
        Development

        Successfully merging a pull request may close this issue.

        4 participants