Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse permit URL #526

Open
rndquu opened this issue Jul 17, 2023 · 36 comments · Fixed by #738 · May be fixed by #828
Open

Parse permit URL #526

rndquu opened this issue Jul 17, 2023 · 36 comments · Fixed by #738 · May be fixed by #828
Labels
Permitted Price: 12.5 USD Priority: 1 (Normal) Time: <1 Hour

Comments

@rndquu
Copy link
Member

rndquu commented Jul 17, 2023 •
edited

Right now here we use a plain string comparison to check that the comment is a permit URL. This approach is brittle.

We should parse URL with URLSearchParams in order to not rely on query parameters order.
@rndquu rndquu mentioned this issue Jul 17, 2023
Merged
@ubiquibot ubiquibot bot mentioned this issue Jul 17, 2023
Closed
@KaffinPX
Copy link

KaffinPX commented Jul 17, 2023 •
edited by 0x4007

/start

@ubiquibot
Copy link

ubiquibot bot commented Jul 17, 2023

Deadline Mon, 17 Jul 2023 21:56:53 GMT
Registered Wallet Please set your wallet address to use `/wallet 0x4FDE...BA18`
Payment Multiplier 1.00
Multiplier Reason undefined
Total Bounty 12.5 USD
Tips:
  • Use /wallet 0x4FDE...BA18 if you want to update your registered payment wallet address @user.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the bounty.

    @KaffinPX
    Copy link

    /unassign

    @ubiquibot
    Copy link

    ubiquibot bot commented Jul 18, 2023

    You have been unassigned from the bounty @KaffinPX

    @rndquu rndquu mentioned this issue Jul 27, 2023
    Closed
    @kamaalsultan
    Copy link
    Contributor

    kamaalsultan commented Jul 31, 2023 •
    edited by 0x4007

    /start

    @ubiquibot
    Copy link

    ubiquibot bot commented Jul 31, 2023

    Deadline Mon, 31 Jul 2023 18:05:26 GMT
    Registered Wallet 0xeFeF11577Db8f882F6Bf92F46008170Ba3602D40
    Payment Multiplier 1.00
    Multiplier Reason
    Total Bounty 18.75 USD
    Tips:
    • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address @user.
    • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
    • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the bounty.

      @kamaalsultan
      Copy link
      Contributor

      /unassign

      @ubiquibot
      Copy link

      ubiquibot bot commented Aug 1, 2023

      You have been unassigned from the bounty @ByteBallet

      @0x4007
      Copy link
      Member

      0x4007 commented Aug 4, 2023

      @rndquu can you verify the example link is a permalink? Looks like the lines have been shifted around and the example is no longer clear, which is why nobody is taking this up I assume.

      @rndquu
      Copy link
      Member Author

      rndquu commented Aug 4, 2023

      @rndquu can you verify the example link is a permalink? Looks like the lines have been shifted around and the example is no longer clear, which is why nobody is taking this up I assume.

      fixed

      @Sadaf-A
      Copy link
      Contributor

      Sadaf-A commented Aug 6, 2023 •
      edited by 0x4007

      /start

      @ubiquibot
      Copy link

      ubiquibot bot commented Aug 6, 2023

      Deadline Sun, 06 Aug 2023 12:11:41 GMT
      Registered Wallet Please set your wallet address to use `/wallet 0x0000...0000`
      Payment Multiplier 1.00
      Multiplier Reason undefined
      Total Bounty 18.75 USD
      Tips:
      • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address @user.
      • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
      • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the bounty.

        @Sadaf-A Sadaf-A mentioned this issue Aug 7, 2023
        Closed
        @0x4007 0x4007 added the ping label Aug 9, 2023
        @0x4007 0x4007 removed the ping label Aug 9, 2023
        @ubiquibot
        Copy link

        ubiquibot bot commented Aug 13, 2023

        Do you have any updates @Sadaf-A? If you would like to release the bounty back to the DevPool, please comment /stop
        Last activity time: Wed Aug 09 2023 20:05:23 GMT+0000 (Coordinated Universal Time)

        @ubiquibot ubiquibot bot unassigned Sadaf-A Aug 16, 2023
        @ubiquibot
        Copy link

        ubiquibot bot commented Aug 16, 2023

        @Sadaf-A - Releasing the bounty back to dev pool because the allocated duration already ended!
        Last activity time: Wed Aug 09 2023 20:05:23 GMT+0000 (Coordinated Universal Time)

        @0x4007
        Copy link
        Member

        0x4007 commented Aug 29, 2023

        /assign

        Pls try the /start command

        I'm considering making a script to edit all the old comments that say /assign to make them say /start

        Executed it on ubiquity-dollar and ubiquibot

        @BeanieMen
        Copy link
        Contributor

        @pavlovcik this issues isnt already done?
        ref

        @rndquu
        Copy link
        Member Author

        rndquu commented Sep 7, 2023

        @pavlovcik this issues isnt already done? ref

        The issue is still relevant

        @Sadaf-A
        Copy link
        Contributor

        Sadaf-A commented Sep 8, 2023

        /start

        @ubiquibot
        Copy link

        ubiquibot bot commented Sep 8, 2023

        Deadline Fri, 08 Sep 2023 01:12:08 UTC
        Registered Wallet 0x0BEd00438D57d07E3667b85Fa8EB86Af147C7025
        Tips:
        • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address @user.
        • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
        • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the bounty.

          @Sadaf-A Sadaf-A mentioned this issue Sep 8, 2023
          Merged
          @ubiquibot ubiquibot bot added the Permitted label Sep 18, 2023
          @ubiquibot
          Copy link

          ubiquibot bot commented Sep 18, 2023

          Task Assignee Reward

          [ CLAIM 18.75 WXDAI ]

          0x0BEd00438...Af147C7025

          If you've enjoyed your experience in the DevPool, we'd appreciate your support. Follow Ubiquity on GitHub and star this repo. Your endorsement means the world to us and helps us grow!
          We are excited to announce that the DevPool and UbiquiBot are now available to partners! Our ideal collaborators are globally distributed crypto-native organizations, who actively work on open source on GitHub, and excel in research & development. If you can introduce us to the repository maintainers in these types of companies, we have a special bonus in store for you!

          @ubiquibot
          Copy link

          ubiquibot bot commented Sep 18, 2023

          Task Creator Reward

          rndquu: [ CLAIM 22.8 WXDAI ]

          @0x4007 0x4007 reopened this Sep 23, 2023
          @ubiquibot ubiquibot bot unassigned Sadaf-A Sep 23, 2023
          @ubiquibot
          Copy link

          ubiquibot bot commented Sep 23, 2023

          @Sadaf-A - Releasing the bounty back to dev pool because the allocated duration already ended!
          Last activity time: Fri Sep 08 2023 00:11:55 GMT+0000 (Coordinated Universal Time)

          @0x4007
          Copy link
          Member

          0x4007 commented Sep 23, 2023

          This was not implemented according to the specification

          @ubiquibot
          Copy link

          ubiquibot bot commented Sep 23, 2023

          @Sadaf-A please be sure to review this conversation and implement any necessary fixes. Unless this is closed as completed, its payment of 18.75 WXDAI will be deducted from your next bounty.

          @Sadaf-A
          Copy link
          Contributor

          Sadaf-A commented Sep 23, 2023 •
          edited

          This was not implemented according to the specification

          hey, @pavlovcik  I'd be happy to pick it up again but my max assigned limit is reached. There was some disagreement on how this change should be handled and it was changed to RegEx from URLParser midway.
          So, what can be done? can you assign this issue to me?

          @ubiquibot
          Copy link

          ubiquibot bot commented Sep 23, 2023

          @Sadaf-A The time limit for this bounty is on Sat, 23 Sep 2023 16:37:38 UTC

          @BeanieMen
          Copy link
          Contributor

          oops

          This was referenced Sep 24, 2023
          Closed
          Open
          @ubiquibot
          Copy link

          ubiquibot bot commented Oct 3, 2023

          Do you have any updates @Sadaf-A? If you would like to release the bounty back to the DevPool, please comment /stop
          Last activity time: Fri Sep 29 2023 09:37:28 GMT+0000 (Coordinated Universal Time)

          @Sadaf-A
          Copy link
          Contributor

          Sadaf-A commented Oct 3, 2023 •
          edited

          Do you have any updates @Sadaf-A? If you would like to release the bounty back to the DevPool, please comment /stop
          Last activity time: Fri Sep 29 2023 09:37:28 GMT+0000 (Coordinated Universal Time)

          the pr is still in review

          @ubiquibot
          Copy link

          ubiquibot bot commented Oct 9, 2023

          Do you have any updates @Sadaf-A? If you would like to release the bounty back to the DevPool, please comment /stop
          Last activity time: Thu Oct 05 2023 16:37:09 GMT+0000 (Coordinated Universal Time)

          @ubiquibot ubiquibot bot unassigned Sadaf-A Oct 12, 2023
          @Sadaf-A
          Copy link
          Contributor

          Sadaf-A commented Oct 24, 2023

          /start

          @ubiquibot
          Copy link

          ubiquibot bot commented Oct 24, 2023

          Skipping /start because it is disabled on this repo

          @Sadaf-A
          Copy link
          Contributor

          Sadaf-A commented Oct 24, 2023

          @pavlovcik I have a open PR which will resolve this issue. could you please assign this to me. also why is the /start command not working for me?

          @korrrba-bot korrrba-bot bot mentioned this issue Nov 6, 2023
          Open
          Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
          Assignees
          No one assigned
          Labels
          Permitted Price: 12.5 USD Priority: 1 (Normal) Time: <1 Hour
          Projects
          None yet
          Milestone
          No milestone
          6 participants
          @0x4007 @BeanieMen @KaffinPX @kamaalsultan @Sadaf-A @rndquu