Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicates bug in Basic-Sunburst #1300

Open
roeezolantz opened this issue Jan 9, 2020 · 0 comments · May be fixed by #1301
Open

Duplicates bug in Basic-Sunburst #1300

roeezolantz opened this issue Jan 9, 2020 · 0 comments · May be fixed by #1301

Comments

@roeezolantz
Copy link

There is a bug in Basic-Sunburst that cause duplicate values from same levels but other hierarchy to be all selected together whenever one of them has to be.

Example :

Given the tree :

  • root
    • one
      • hello
    • two
      • hello
    • three
      • hello

with the given path : root > one > hello

All 3 hello items will be marked because the updateData recursion could not treat duplicates.
In fact, this could be solved with a minor change for this recursion that will seep the validity of each node down to its children

roeezolantz pushed a commit to roeezolantz/react-vis that referenced this issue Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant