Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PEP 517 builds #340

Open
Zaczero opened this issue Jan 8, 2024 · 3 comments
Open

Support PEP 517 builds #340

Zaczero opened this issue Jan 8, 2024 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@Zaczero
Copy link

Zaczero commented Jan 8, 2024

When attempting to install the h3:

Note: This error originates from the build backend, and is likely not a problem with poetry but with h3 (3.7.6) not supporting PEP 517 builds. You can verify this by running 'pip wheel --no-cache-dir --use-pep517 "h3 (==3.7.6)"'.

@ajfriend
Copy link
Contributor

Yes. I'd like to improve the current build setup, possibly using https://scikit-build-core.readthedocs.io/

PRs more than welcome in the meantime!

@ajfriend ajfriend added the help wanted Extra attention is needed label May 28, 2024
@wingkitlee0
Copy link

I was reading "modern build setup" these days.
It seems that the Cython support in scikit-build-core is still in development: https://scikit-build-core.readthedocs.io/en/latest/getting_started.html#source-code but it may have everything we need?

I was looking into meson/meson-python as well. There are currently used in scipy and scikit-image.
https://meson-python.readthedocs.io/en/latest/

@ajfriend
Copy link
Contributor

Do you know if meson works well with CMake? The H3 C library uses CMake, so we need to interface with it. IIRC, this is why we were using scikit-build originally.

Aside from meson, scikit-build-core does look promising, I just haven't had a chance to try building with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants