Skip to content
This repository has been archived by the owner on Oct 3, 2022. It is now read-only.

Scatterplot first code does not work #97

Open
RenatoArbex opened this issue Jun 24, 2019 · 2 comments
Open

Scatterplot first code does not work #97

RenatoArbex opened this issue Jun 24, 2019 · 2 comments

Comments

@RenatoArbex
Copy link

RenatoArbex commented Jun 24, 2019

I'm following the tutorial but ran into the following issue. The code before "2. Add data" in https://vis.academy/#/building-a-geospatial-app/2-map-data-overlays-scatterplot
does not work for me. After examinating the full complete code, which works fine, I noticed a difference in
<StaticMap style={this.state.style} />

In the full complete working code, it is like this:
<StaticMap mapStyle={this.state.style} />

I replaced style with mapStyle as in the working code and it works fine now. Please correct this as I was struggling with this issue for some time till I found out this typo. Thanks!

@Rafnuss
Copy link

Rafnuss commented Dec 27, 2019

Thanks @RenatoArbex , I spent 20minutes looking for what was wrong...
Also, there is another type at http://vis.academy/#/building-a-geospatial-app/1-starting-with-a-map,

<MapGL
          {...this.state.viewport}
          mapStyle={this.state.style}
        </MapGL>

should be:

<MapGL
          {...this.state.viewport}
          mapStyle={this.state.style}
>
</MapGL>

@mmyrte
Copy link

mmyrte commented Sep 16, 2020

I did a diff on the src/demos/building-a-geospatial-app/ subdirectories starting-code and 2-scatterplot-overlay - apparently, the src/controls.js files have diverged at some point. If you just copy over the code from the scatterplot step to the starting step, it runs fine.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants