Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please make a new release of phabricator-jenkins-plugin #358

Open
pasikarkkainen opened this issue Feb 24, 2023 · 9 comments
Open

Please make a new release of phabricator-jenkins-plugin #358

pasikarkkainen opened this issue Feb 24, 2023 · 9 comments

Comments

@pasikarkkainen
Copy link

pasikarkkainen commented Feb 24, 2023

PR 357 (#357) has been merged, so please make a new release, especially when this fixes CVE security bugs!

Latest release (v2.1.5) is over 2 years old now, from Jan 2021.

Ref #356 and #337

@valerio-bozzolan
Copy link

valerio-bozzolan commented Mar 13, 2023

I'm not 100% sure but I think the maintainer needs to put 2.1.6 in build.gradle and then:

git add build.gradle
git commit -m "Update for 2.1.6 release"
git tag phabricator-plugin-2.1.6
git push --tags
gradle clean publish

Source: https://wiki.jenkins-ci.org/display/JENKINS/Gradle+JPI+Plugin

Before that, maybe also editing the changelog.md may be useful, to mention that HTTP client dependency was fixed.

(I honestly just know git, Phabricator/Phorge and Java. I don't know Jenkins at all. I don't think I can be the new maintainer.)

@valerio-bozzolan
Copy link

Hi @jonathanbaker7 - if you have 8 minutes, a small action is required here again 💛

Then we will help in finding another maintainer... it's a promise... 😄

@kislinsk
Copy link

We are having the same issue. The plugin is not able to talk to Phabricator anymore. Is it possible to install the plugin directly from this repo based on a commit or are we blocked until an official release is published?

@valerio-bozzolan
Copy link

valerio-bozzolan commented Mar 17, 2023

@kislinsk I suggest to manually compile this plugin and adopt that, so you don't need to wait an official Uber release.

@kislinsk
Copy link

Thanks @valerio-bozzolan. I have no idea how that works but I try to figure it out. :)

@valerio-bozzolan
Copy link

valerio-bozzolan commented Mar 17, 2023

I'm honestly confused as you are. From the README I see this page:

https://wiki.jenkins-ci.org/display/JENKINS/Gradle+JPI+Plugin

So it says that to build you have to run this:

gradle jpi

That should create a .hpi file.

If I do that, on gradle 4.4.1 I just get an exception Could not find method register(). Please try on your environment as well.

@kislinsk
Copy link

I have to stop for today but I just managed to at least successfully build the plugin after many failed attempts on CentOS and various combinations of Gradle and OpenJDK. It finally worked on Windows with a rather old version of Gradle v5.6.4 and OpenJDK 11.

@kislinsk
Copy link

Works for us! I deployed the built plugin via the Plugin Manager Web UI.

@kwisatz
Copy link

kwisatz commented Apr 7, 2023

Build worked fine for me:

kwisatz@thufir:~/1024/projects//phabricator-jenkins-plugin - master $ ./gradlew jpi
Downloading https://services.gradle.org/distributions/gradle-4.10.3-bin.zip
..........................................................................

Welcome to Gradle 4.10.3!

Here are the highlights of this release:
 - Incremental Java compilation by default
 - Periodic Gradle caches cleanup
 - Gradle Kotlin DSL 1.0-RC6
 - Nested included builds
 - SNAPSHOT plugin versions in the `plugins {}` block

For more details see https://docs.gradle.org/4.10.3/release-notes.html

Starting a Gradle Daemon (subsequent builds will be faster)

> Task :compileJava
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /home/kwisatz/1024/projects/phabricator-jenkins-plugin/src/main/java/com/uber/jenkins/phabricator/PhabricatorBuildWrapper.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 5.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/4.10.3/userguide/command_line_interface.html#sec:command_line_warnings

BUILD SUCCESSFUL in 48s
7 actionable tasks: 7 executed

kwisatz@thufir:~/1024/projects/phabricator-jenkins-plugin - master $ file build/libs/phabricator-plugin.hpi 
build/libs/phabricator-plugin.hpi: Zip archive data, at least v1.0 to extract

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants