Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phabricator comment is not posted to commits #224

Open
na-Itms opened this issue Jun 12, 2017 · 0 comments
Open

Phabricator comment is not posted to commits #224

na-Itms opened this issue Jun 12, 2017 · 0 comments

Comments

@na-Itms
Copy link
Contributor

na-Itms commented Jun 12, 2017

First of all I apologize if this is a duplicate of #120. It looks like the other issue is a low-priority code refactoring, whereas I believe I'm facing a bug.

We have a few jobs that are triggered by commits, and Harbormaster correctly posts "completed building" messages to those commits. However, the custom Phabricator comment which contains all the interesting information is not posted. The issue does not happen for differentials.
For information, the checked options are "Comment on Success" and "Add Custom Comment" (the job script is in theory always successful).
The plugin version is 1.9.7.

Thanks in advance 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant