Skip to content
This repository has been archived by the owner on Feb 18, 2021. It is now read-only.

ConcurrentMap size calculation is wrong? #338

Open
wxing1292 opened this issue Dec 1, 2017 · 0 comments
Open

ConcurrentMap size calculation is wrong? #338

wxing1292 opened this issue Dec 1, 2017 · 0 comments

Comments

@wxing1292
Copy link

Please see the followings:

  1. Remove decrement the counter with no checking of whether key exists or not:
    https://github.com/uber/cherami-server/blob/master/common/concurrentmap.go#L173

  2. Put increase the counter with no checking of whether key exists or not:
    https://github.com/uber/cherami-server/blob/master/common/concurrentmap.go#L148

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant