Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALL facebook.com issues #3367

Open
GetGankNow opened this issue Aug 30, 2018 · 812 comments
Open

ALL facebook.com issues #3367

GetGankNow opened this issue Aug 30, 2018 · 812 comments

Comments

@GetGankNow
Copy link

GetGankNow commented Aug 30, 2018

URL(s) where the issue occurs

Facebook.com

Describe the issue

The Facebook sponsored ads is appearing again, i have tried all the solutions but nothing works

Versions

  • Browser/version: [Chrome 68.0.3440.106]
  • uBlock Origin version: [1.16.18]

Settings

  • [Default]
@KiLL4FuNK
Copy link

I see nothing Can it be adware?
you have to see what programs you installed any
check if you do not have some rare extensions

@GetGankNow
Copy link
Author

No i don't have any adware or some adware extensions, the ads are from Facebook ( sponsored )

@mapx-
Copy link
Contributor

mapx- commented Aug 31, 2018

While on a page with ads, right click on page, save as ..., you'll get a folder + html page, zip them together, upload the zip on some free server. Post here the link.

@GetGankNow
Copy link
Author

Here the page with the sponsored ad: https://ufile.io/y827j

@mapx-
Copy link
Contributor

mapx- commented Aug 31, 2018

@GetGankNow test this filter
facebook.com##.userContentWrapper :has([id^="feed_subtitle_"]:has-text(Sp))

@GetGankNow
Copy link
Author

@mapx- is blocking all post but allowing the comment section and reaction section.

@mapx-
Copy link
Contributor

mapx- commented Aug 31, 2018

facebook.com###substream_1:has([id^="feed_subtitle_"]:has-text(Sp))

@GetGankNow
Copy link
Author

@mapx- works bro, thanks a lot.

@GetGankNow
Copy link
Author

GetGankNow commented Aug 31, 2018

Edit: some sponsored ads are appearing again.

@mapx-
Copy link
Contributor

mapx- commented Aug 31, 2018

another example page ?

@GetGankNow
Copy link
Author

The page that i save include all ads, i don't know how to save the page without the ads of this: facebook.com###substream_1:has([id^="feed_subtitle_"]:has-text(Sp))

@GetGankNow
Copy link
Author

facebook.zip
Here the page again.

@mapx-
Copy link
Contributor

mapx- commented Sep 1, 2018

test

facebook.com##[id^=hyperfeed_story_id_]:has(a[href*="client_token"])
facebook.com##[id^=hyperfeed_story_id_]:has(a[href*="utm_campaign"])

@uBlockOrigin uBlockOrigin deleted a comment Sep 1, 2018
@GetGankNow
Copy link
Author

@mapx- this 3 rules works. Thanks for all!!

@mapx- mapx- closed this as completed in d1b91d6 Sep 1, 2018
ZaphodBeebblebrox added a commit that referenced this issue Sep 1, 2018
mapx- added a commit that referenced this issue Sep 6, 2018
@ghajini
Copy link
Collaborator

ghajini commented Sep 9, 2018

ads 'sponsored'

screenshot 41c

@mapx-
Copy link
Contributor

mapx- commented Sep 9, 2018

test
facebook.com##[id^=hyperfeed_story_id_]:has([id^=u_fetchstream_2_1]:has-text(SpSonSsoSredS))
or
facebook.com##[id^=hyperfeed_story_id_]:has([id^=u_fetchstream_2_1]:has-text(Sp))

@ghajini
Copy link
Collaborator

ghajini commented Sep 9, 2018

not working bro
screenshot 42

@mapx-
Copy link
Contributor

mapx- commented Sep 9, 2018

weird, working for me (exactly using your test-case)

Did you test the same case you uploaded ? or something new ? could be "they" are using different approaches

@shuhaowu
Copy link

Doesn't work for me either. I had to use something like this:

facebook.com##[id^=hyperfeed_story_id_]:has([id^=feed_subtitle_]:has-text(SpSonSsoSredS))

However, with this filter active, FB seems to be refreshing the posts in an infinite loop.

@filbo
Copy link

filbo commented Sep 13, 2018

From about 3mo to about 2wk ago, it was possible to catch Sponsored posts with :has-text(SpSonSsoSredS). This appeared only in Sponsored posts, with the 'S' elements hidden by CSS. (I'm not sure about back then, but now, the hiding CSS uses 'font-size:0', not 'display:none'.)

About 2wk ago, they started putting that stuff into all(*) posts. In Sponsored posts they use CSS to hide the 'S' elements. In 'normal' posts they use CSS to hide all of this. :has-text() is not aware of CSS hiding. The CSS used for this hiding is cryptographically hashed; so far it has remained stable for me, but another user has completely different classes, so the simple selector I use in my own filter won't work for anyone else. So we have to get into runtime evaluation of CSS computed styles :(

[(*)Not really 'all', but all normal posts by users, and many Sponsored posts, although some emitted by other modules inside FB don't use this particular trickery.]

It seems like uBO :matches-css() [see: https://github.com/gorhill/uBlock/wiki/Procedural-cosmetic-filters] might be able to handle this. Something like:

facebook.com##[id^=hyperfeed_story_id_]:if([id^=feed_subtitle_] span:has-text(^Sp$):matches-css(:not(display:none)))

-- which is COMPLETELY UNTESTED, just a pile of syntax smashed together by hand. Not sure if the nested uBO selectors are supported...

And all they need to do to break this is chop the word 'Sponsored' up differently; and it won't work for other UI languages. This is getting ugly.

@kowith337
Copy link

kowith337 commented Sep 13, 2018

Maybe need to view the deep of they DOM tag, e.g. looking in data-ajaxify, data-sigil, data-uri, data-ft, data-xt, ...

for example, I've found some part of sponsored URLs have is_sponsored=1 parameter, sometime it's boxed the parameter like [is_sponsored]=1

@wtchangdm
Copy link

wtchangdm commented Sep 13, 2018

Hi, I saw the comment in filters so I'd like report here:
I am not sure if is region-related, but the following rule is killing my timeline (using https://www.facebook.com/?sk=h_chr). All of the posts are hidden now.

facebook.com##[id^=hyperfeed_story_id_]:has([id^=feed_subtitle_]:has-text(SpSonSsoSredS))

Thanks.

mapx- added a commit that referenced this issue Sep 13, 2018
@Yuki2718
Copy link
Contributor

Yuki2718 commented May 5, 2024

Okay, I can reproduce.
@stephenhawk8054 as we now have better fix, maybe limit to https://www.facebook.com/ or even disable?

Yuki2718 added a commit that referenced this issue May 5, 2024
@Yuki2718
Copy link
Contributor

Yuki2718 commented May 5, 2024

Making the length requirement to 290 also helps and on my end this still catches ads in main feed. I'll change the length too. But I don't see incorrect blocking by ##div[aria-describedby]:not([aria-posinset]) :is(h3, h4) span > a[href]:not([href^="/groups/"]):not([href*="section_header_type"]):matches-attr(href="/__cft__\[0\]=[-\w]{270,}/"):upward(div[aria-describedby]):style(height: 0 !important; overflow: hidden !important;).

Yuki2718 added a commit that referenced this issue May 5, 2024
@zbluebugz
Copy link

Changing the length from 270 to 290 works in my news + page feeds.

Bonus: Also filters out Sponsored · Paid for by ______ posts as well.

@Yuki2718
Copy link
Contributor

Yuki2718 commented May 5, 2024

Changing the length from 270 to 290 works in my news + page feeds.

Bonus: Also filters out Sponsored · Paid for by ______ posts as well.

What are them? URL?
BTW found ads on https://www.facebook.com/search/top/?q=news On my end it's always on top and thus on doc so not covered by ##+js(trusted-replace-xhr-response, /\{"node":\{"role":"SEARCH_ADS"[^\n]+?cursor":[^}]+\}/g, {}, /api/graphql) but langage-independent fix won't be trivial.

Yuki2718 added a commit that referenced this issue May 5, 2024
@zbluebugz
Copy link

News Feed = Home page
Page Feed = "Posts" feed in a a page your follow. E.g. the above https://facebook.com/animategamer

Other Feeds
All Feeds = https://www.facebook.com/?filter=all&sk=h_chr
All Feeds > Pages = https://www.facebook.com/?filter=pages&sk=h_chr

Sponsored · Paid for by ______ - Similar to a Sponsored post - but is a Page's post being promoted/sponsored by another page. Usually appears in the main News Feed. Don't see them often - saw 2-3 today.
image

As for Search Feed results, your suggestion did not work for me. (W10, FF 125.0.3, uBO 1.57.2).

I've found this one to work for me:

! - search feed
facebook.com##:matches-path(/search/) div[role="article"] span > a[href]:not([href^="/groups/"]):not([href*="section_header_type"]):matches-attr(href="/__cft__\[0\]=[-\w]{270,}/"):upward([role="article"]):style(height: 0 !important; overflow: hidden !important;)

Note: You might need to adjust the 270 down to 254 ... I've used 254 with no issues for many months.

@sirald66
Copy link

sirald66 commented May 5, 2024

FYI, a Facebook issue unrelated directly to uBO, but maybe has impact:

Facebook is currently having an issue starting Friday May 3rd, 2024 at ~6:00 PM MT where members can not see the lists of Posts (other than Featured) using browsers (not apps) in groups across OS and devices; if the group's default Post Sort order is set to anything but Most Relevant. This has been confirmed through unofficial group admin support groups. It seemingly does not affect all accounts, but many are noticing.

@D4niloMR
Copy link
Contributor

D4niloMR commented May 5, 2024

BTW found ads on https://www.facebook.com/search/top/?q=news

Working on FF and Chromium:

www.facebook.com##+js(json-prune, require.0.3.0.__bbox.require.[].3.1.__bbox.result.data.serpResponse.results.edges.[-].relay_rendering_strategy.view_model.story.sponsored_data.ad_id)

@stephenhawk8054
Copy link
Member

stephenhawk8054 commented May 6, 2024

BTW found ads on https://www.facebook.com/search/top/?q=news

Working on FF and Chromium:

www.facebook.com##+js(json-prune, require.0.3.0.__bbox.require.[].3.1.__bbox.result.data.serpResponse.results.edges.[-].relay_rendering_strategy.view_model.story.sponsored_data.ad_id)

It works for me

@Yuki2718
Copy link
Contributor

Yuki2718 commented May 6, 2024

Working, didn't think of json-prune. Should this make www.facebook.com##+js(trusted-replace-xhr-response, /\{"node":\{"role":"SEARCH_ADS"[^\n]+?cursor":[^}]+\}/g, {}, /api/graphql) redundant?

Other Feeds

Do they have ads? I so far don't see.

I've found this one to work for me:

! - search feed
facebook.com##:matches-path(/search/) div[role="article"] span > a[href]:not([href^="/groups/"]):not([href*="section_header_type"]):matches-attr(href="/__cft__\[0\]=[-\w]{270,}/"):upward([role="article"]):style(height: 0 !important; overflow: hidden !important;)

Note: You might need to adjust the 270 down to 254 ... I've used 254 with no issues for many months.

Yeah, it works regardless of languages. But on my end 270 is enough, do you see ads if set to 270?

Yuki2718 added a commit that referenced this issue May 6, 2024
@stephenhawk8054
Copy link
Member

stephenhawk8054 commented May 6, 2024

Working, didn't think of json-prune. Should this make www.facebook.com##+js(trusted-replace-xhr-response, /\{"node":\{"role":"SEARCH_ADS"[^\n]+?cursor":[^}]+\}/g, {}, /api/graphql) redundant?

Sometimes json-prune can't catch the data in the JSONL responses from XHR. For example, when I go to https://www.facebook.com/search/top?q=camera (and scroll down), there's no json-prune matches if I'm not wrong.

@zbluebugz
Copy link

Other Feeds

Do they have ads? I so far don't see.

Yes, I've seen Sponsored posts in "Feeds > All" and "Feeds > Pages".

Yeah, it works regardless of languages. But on my end 270 is enough, do you see ads if set to 270?

After short time using 270 on search results pages, a few have slipped through - their lengths were 266.
I've used 254 for a long time without issues (within the search results pages).

Yuki2718 added a commit that referenced this issue May 7, 2024
@Yuki2718
Copy link
Contributor

Yuki2718 commented May 7, 2024

I set to 265 as we have json-prune. Didn't know :matches-path() takes query as path.

@ghajini ghajini mentioned this issue May 7, 2024
11 tasks
@michaelboatright
Copy link

michaelboatright commented May 7, 2024

Sorry for opening #23603; Starting last night, around 00:00 UTC, started getting ads on Facebook unfiltered feed (https://www.facebook.com/?sk=h_chr).
Configuration:
uBlock Origin: 1.57.2
Firefox: 125.0.3
Screen Shot 2024-05-07 at 10 11 10 AM
Screen Shot 2024-05-07 at 10 21 51 AM

filterset (summary):
network: 136169
cosmetic: 31501
scriptlet: 19330
html: 1777
listset (total-discarded, last-updated):
default:
user-filters: 0-0, never
ublock-filters: 38069-306, 46m Δ
ublock-badware: 8521-0, 46m Δ
ublock-privacy: 885-3, 46m Δ
ublock-unbreak: 2327-3, 46m Δ
ublock-quick-fixes: 193-18, 46m Δ
easylist: 87364-15338, 46m Δ
easyprivacy: 50868-67, 46m Δ
urlhaus-1: 13865-0, now
plowe-0: 3731-1160, now
filterset (user): [empty]
trustedset:
added: [array of 10 redacted]
userSettings:
ignoreGenericCosmeticFilters: true
hiddenSettings: [none]
supportStats:
allReadyAfter: 754 ms (selfie)
maxAssetCacheWait: 503 ms
cacheBackend: indexedDB
popupPanel:
blocked: 1
network:
facebook.com: 1
extended:
##+js(json-prune, require.0.3.0.__bbox.require.[].3.[-].__bbox.r…
##+js(json-prune, require.0.3.0.__bbox.require.[].3.1.__bbox.res…

@zbluebugz
Copy link

@michaelboatright try this - made specifically for the url you provided.

Add to My filters:

www.facebook.com##:matches-path(/^\/\?sk=h_chr$/) div[aria-posinset] span > a[href]:not([href^="/groups/"]):not([href*="section_header_type"]):matches-attr(href="/__cft__\[0\]=[-\w]{290,}/"):upward(div[aria-posinset]):style(height: 0 !important; overflow: hidden !important;)

@michaelboatright
Copy link

michaelboatright commented May 7, 2024 via email

@u-RraaLL
Copy link
Contributor

u-RraaLL commented May 7, 2024

Yes, you can test by pasting into "My filters" and hitting Apply.

BTW - please do not reply via email.

@michaelboatright
Copy link

michaelboatright commented May 8, 2024 via email

@Yuki2718
Copy link
Contributor

Yuki2718 commented May 8, 2024

Shouldn't that be covered by f743632 ? Update filters and test again.

@michaelboatright
Copy link

michaelboatright commented May 8, 2024 via email

stephenhawk8054 added a commit that referenced this issue May 10, 2024
@Copperplate
Copy link

uBlock Origin is forcing any YouTube link thumbnails in Facebook posts to disappear. Everything works when I disable uBlock origin. Thanks for looking into this.

@stephenhawk8054
Copy link
Member

stephenhawk8054 commented May 11, 2024

@Copperplate Can you test these filters?

facebook.com#@#a[aria-label][href*="&fbclid="]
facebook.com#@#a[aria-label][href*="26fbclid%"]

Click on uBO icon > ⚙ Dashboard button > Add the filter(s) in "My filters" pane > ✓ Apply changes > Open new tab and test again.

Yuki2718 added a commit that referenced this issue May 11, 2024
@Copperplate
Copy link

Thanks so much, @stephenhawk8054 and @Yuki2718 ! I didn't get a chance to test those filters, but as of the time of this message, the issue appears to be resolved on Facebook, and YouTube thumbnails are now showing correctly in posts. Thank you for all your hard work! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests