Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal Grid Lines Not Working on Line Charts #189

Open
sjv0 opened this issue Jan 15, 2024 · 1 comment
Open

Horizontal Grid Lines Not Working on Line Charts #189

sjv0 opened this issue Jan 15, 2024 · 1 comment

Comments

@sjv0
Copy link

sjv0 commented Jan 15, 2024

If you take the example line chart from the documentation and append &chg=1,0, you get vertical grid lines as expected. If you add &chg=0,1 instead, horizontal grid lines are not drawn.

Example Line Chart Vertical

Example Line Chart Horizontal

Looking at the toChartJs function in google_image_charts.js I note that it calls setGridLines() twice, and the file also contains two separate implementations of the setGridLines function. The first sets maxTicksLimit and the second sets gridLines.display and gridLines.drawOnChartArea.

I don't know how Javascript handles calls to a function that's implemented twice, but I note that if I append &format=chartjs-config to the URLs, the one that works has drawOnChartArea set to true and the one that doesn't work has drawOnChartArea set to false.

I don't have a suitable test environment to suggest a fix, but hopefully the above information is helpful in identifying the problem. Thanks so much in advance.

@typpo
Copy link
Owner

typpo commented Jan 15, 2024

Thanks for catching this. I have a fix in #190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants