Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle general semver ranges, not just >= #36

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

legobeat
Copy link

@legobeat legobeat commented May 15, 2023

Fixes #37

  • Replace abandoned dependency semver-compare with semver
    • semver@5.7.1 is last version without nodejs version restriction
  • Support any version spec, not just single simple >=X.
  • Add generic message when the problem is not simply being below min version (for example: user is on 13 while engines.node is ^12 || >=14).
  • Offloads all string-parsing from this module, making it simpler and more maintainable.

@legobeat
Copy link
Author

@typicode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Does not handle >
1 participant