Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Does not handle > #37

Open
legobeat opened this issue May 15, 2023 · 0 comments · May be fixed by #36
Open

bug: Does not handle > #37

legobeat opened this issue May 15, 2023 · 0 comments · May be fixed by #36

Comments

@legobeat
Copy link

legobeat commented May 15, 2023 •
edited

Example scenario:

  • user on Node.js v10.24.1
  • package foo: engines.node=>10

The field can be any valid semver range.

Expected behavior:

error:

foo requires at least version 11.0.0 of Node, please upgrade

Actual behavior

Version test succeeds

Failing test-case: 99b6ebd
@legobeat legobeat linked a pull request May 15, 2023 that will close this issue
Open
@legobeat legobeat changed the title bug: Does not handles > bug: Does not handle > May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

handle general semver ranges, not just >= legobeat/please-upgrade-node
1 participant
@legobeat