Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users data corrupted #30

Closed
rmat0n opened this issue May 12, 2016 · 7 comments
Closed

Users data corrupted #30

rmat0n opened this issue May 12, 2016 · 7 comments

Comments

@rmat0n
Copy link

rmat0n commented May 12, 2016

Hi, seems that /users is corrupted as it returns 20 users (instead of 10). Note that some of them have no data inside, see curl output in this file.
Thanks

@Jotunblood
Copy link

Most all of the data is corrupted, and /posts is a jumbled mess. I also sent an email in hopes that this gets resolved quickly.

@capslockpirate
Copy link

Just did a test, looks like whatever prevented actually creating and deleting records changed somehow, I was able to actually create a new user that was persisted:
{ name: "test", email: "test@testing.test", website: "google.com", id: 18 }

@typicode
Copy link
Owner

Thank you for the heads up. I'll have a look right now.

@typicode
Copy link
Owner

I did a rollback, so it should be good for now.

I think I know where the problem is. I'll update this issue when it'll be fixed for good.

@typicode
Copy link
Owner

There was a breaking change in lowdb API and I didn't update JSONPlaceholder accordingly. I've deployed the fix so it should be good now.

Tests have been updated too.
I'm testing now that concurrent requests don't modify data to be sure it won't happen again.

Sorry for any inconvenience, and thanks a lot again all for letting me know :) 👍

@rmat0n
Copy link
Author

rmat0n commented May 13, 2016

@typicode well done! great service btw 😉

@typicode
Copy link
Owner

@rmat0n thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants