ExitCase lost in several places

[kubukoz]

Hi!

I noticed that allocated is used several times instead of allocatedCase. If I got it right, this would mean that the ExitCase that the finalizer of a resource receives will always be ExitCase.Succeeded, even if wrapped in another Resource.apply.

The relevant spots are:

natchez/modules/mtl/shared/src/main/scala/LocalTrace.scala

Line 39 in d1513b8

t.span(name, options).allocated.map { case (child, release) =>

natchez/modules/core/shared/src/main/scala/Trace.scala

Line 180 in d1513b8

span.span(name, options).allocated.map { case (child, release) =>

(there are actually more in that file)

I believe for a correct implementation these should be replaced with the case-aware variants. Otherwise, the resources being wrapped will never be closed with a Canceled/Errored exit.

[kubukoz]

I suppose the code was written back in the day of CE2, when we didn't have allocatedCase. Also, instead of Resource.apply we should probably be using applyFull and wrapping the underlying resource in cancelable