Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate span values to children spans #17

Open
mijicd opened this issue Aug 30, 2019 · 2 comments
Open

Propagate span values to children spans #17

mijicd opened this issue Aug 30, 2019 · 2 comments

Comments

@mijicd
Copy link
Contributor

mijicd commented Aug 30, 2019

There should be possible to automatically propagate some values (e.g. correlation ids) from parent to its children. I propose to make this the default behavior of put, and to add putLocal which should be used to add span-local values.

@tpolecat
Copy link
Member

I think there are three scopes that matter:

  • span - local to the span, for operation-specific attributes (method arguments)
  • local subtree - propagated to the subtree but not across remote calls, for machine-specific attributes (local uri, hostname)
  • global subtree - propagated to the subtree, including remote calls (trace id, initial uri, user)

I have a WIP that requires you to specify the scope with put. I think there probably shouldn't be a default.

@mijicd
Copy link
Contributor Author

mijicd commented Aug 30, 2019

These looks even better. I mentioned default behavior because my proposal was to have 2 separate methods (put and putLocal) where put would the propagation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants