Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should http.status_code be an Integer, not a String? #7

Open
blandflakes opened this issue Apr 2, 2021 · 0 comments
Open

Should http.status_code be an Integer, not a String? #7

blandflakes opened this issue Apr 2, 2021 · 0 comments

Comments

@blandflakes
Copy link

blandflakes commented Apr 2, 2021

Hello, we're using natchez for tracing, very pleased.

We're trying to bump to 0.0.22, but our HTTP4s services start failing requests due to a ClassCastException.

I did some digging, and I found the cause. Recent versions of dd-trace have started looking at the http.status_code flag, which is expected to be an Integer, not a String:

DataDog/dd-trace-java@e6a2a36#diff-9df24c921979abf616256e047e43b08aa0ad40ef7ac721632512765ec47e1b9cL103

This only recently started breaking because the status code was hardcoded to 0 before; they weren't examining the tag.

The documentation for natchez-https perhaps hints that the String type is surprising, if I'm interpreting "String (!)" correctly.

Is there a reason it's a String, or would you be open to moving it to an Int? I'm happy to contribute with a PR if that's something you'd like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant