You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, thanks for the great work on this lib & others !
Steps to reproduce : fail a traced http route, for instance with IO.raiseError(new RuntimeException)
Expected : no "error.message" mapping, or default to empty string
Actual : NullPointerException is raised by Natchez Middleware, as the Circe Encoder fails to encode null value as a string (used with LogTracer).
Hi, thanks for the great work on this lib & others !
Steps to reproduce : fail a traced http route, for instance with IO.raiseError(new RuntimeException)
Expected : no "error.message" mapping, or default to empty string
Actual : NullPointerException is raised by Natchez Middleware, as the Circe Encoder fails to encode null value as a string (used with LogTracer).
https://github.com/tpolecat/natchez-http4s/blob/main/modules/http4s/src/main/scala/natchez/http4s/NatchezMiddleware.scala#L62
-> I guess we cannot expect every java + scala codebase with dependencies to always have a message value, and I believe this line should be null checked.
Also in core natchez, a fail-fast null check on put method could be helpful.
The text was updated successfully, but these errors were encountered: