Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sizeIs method like std-lib to cats.Reducible and/or NonEmpty collections #4481

Open
xuwei-k opened this issue Jul 17, 2023 · 1 comment

Comments

@xuwei-k
Copy link
Contributor

xuwei-k commented Jul 17, 2023

https://github.com/scala/scala/blob/8ad582dec8ec6d671a36436766bc6c789d2cdbda/src/library/scala/collection/Iterable.scala#L290-L304

@satorg
Copy link
Contributor

satorg commented Jul 17, 2023

Perhaps, it would make sense indeed, but why do you think it should be limited to cats.Reducible and non-empty collections only? Currently, the Reducible's base trait UnorderedTraverse already has just size. Perhaps, it would be better to think about adding sizeIs/sizeCompare to the latter, wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants