Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Scala 3 update #411

Closed
wants to merge 1 commit into from
Closed

Conversation

regadas
Copy link
Collaborator

@regadas regadas commented May 13, 2022

This is merely an evaluation of the new setting coming up in sbt 1.7.0 and the new compiler flag in scala 3.1.2 that allows setting the output target.

@johnynek Since this relies on a milestone version not sure if you wanna go for it.

Fixes #285
Closes #408

@codecov-commenter
Copy link

Codecov Report

Merging #411 (5b97208) into main (74f08bf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #411   +/-   ##
=======================================
  Coverage   95.14%   95.14%           
=======================================
  Files           9        9           
  Lines        1338     1338           
  Branches      124      124           
=======================================
  Hits         1273     1273           
  Misses         65       65           
Impacted Files Coverage Δ
...shared/src/main/scala/cats/parse/Accumulator.scala 97.56% <0.00%> (-2.44%) ⬇️
core/shared/src/main/scala/cats/parse/Parser.scala 94.63% <0.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74f08bf...5b97208. Read the comment docs.

@armanbilge
Copy link
Member

FYI, it seems the Scala 3 team has decided to go in another direction. The new compiler flag has been removed from Scala 3.2.0.

https://github.com/scala/scala-lang/blob/1495481107e3ae5f05acf66160bc6bfd8c65e344/blog/_posts/2022-05-30-long-term-compatibility-plans.md

@johnynek
Copy link
Collaborator

johnynek commented Jun 9, 2022

I guess we should wait until the next version of cats which gets scala native and I think may push us up to 3.1 publishing anyway.

@regadas
Copy link
Collaborator Author

regadas commented Jun 9, 2022

@johnynek Yup that makes sense! I'll close this not this was some exploratory stuff anyway. 😄 Thx

@regadas regadas closed this Jun 9, 2022
@regadas regadas deleted the update_scala_3 branch June 9, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set up CI to use latest scala 3 but publish on oldest scala 3
4 participants