Feat CTRL + Y to submit the solution #1419
Merged
+22
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@sital002 is attempting to deploy a commit to the trash company Team on Vercel. A member of the Team first needs to authorize it. |
|
E2E report: https://256e75c8.typehero-70p.pages.dev |
bautistaaa
reviewed
Feb 13, 2024
packages/monaco/src/index.tsx
Outdated
| const onSubmit = (e: KeyboardEvent) => { | ||
| if ((e.ctrlKey || e.metaKey) && e.code === 'KeyY') { | ||
| e.preventDefault(); | ||
| if (submitButtonRef.current) { |
There was a problem hiding this comment.
you don’t need to simulate clicking the button. just call the same function
There was a problem hiding this comment.
I tried calling the handleSubmit function but when directly calling the handleSubmit the tsErros will be undefined so every submit passed
There was a problem hiding this comment.
quick update it's now working the linter didn't give me any warning regarding missing dependency.
|
@bautistaaa can you review this PR. |
bautistaaa
approved these changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have added a shortcut (CTRL + Y )to submit the solution.
Related Issue
Closes #1408
Motivation and Context
How Has This Been Tested?
Screenshots/Video (if applicable):