Update polyfilling with core-js #363
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
GertSallaerts
force-pushed
the
chore/upgrade-core-js
branch
from
100f33e
to
f23a443
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
core-js@2is obsolete and pollutes the global namespace@babel/preset-env'scorejs: 3option includescore-js@3and its polyfills pollute the global namespace too@babel/plugin-transform-runtime'scorejs: 3option includescore-js-pure@3which does not pollute the global namespace but polyfills everything regardless of the targets specified by preset-env.Would also resolve #342
Solution
By using the new Babel Polyfills we can include modern and pure polyfills based on the targets config (none is specified in twitter-text so it will use the default) in the root of babel config.