Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portugal flag incorrect #414

Closed
VeeBack opened this issue May 12, 2020 · 8 comments
Closed

Portugal flag incorrect #414

VeeBack opened this issue May 12, 2020 · 8 comments

Comments

@VeeBack
Copy link

VeeBack commented May 12, 2020

The Portugal flag is incorrect, the top right line is messed up

https://raw.githubusercontent.com/twitter/twemoji/master/assets/svg/1f1f5-1f1f9.svg

@jdecked
Copy link
Contributor

jdecked commented Jun 3, 2020

We're working on fixing this, but PRs welcome if you can do it quicker. Thanks for reporting.

@VeeBack
Copy link
Author

VeeBack commented Jun 3, 2020

I don't know how to do it unfortunately

@MyriaCore
Copy link

@HVEVB AFAIK, changing the artwork yourself and submitting a PR should be sufficient. So:

  1. Fork this repo
  2. Make a new branch in your fork specifically for this issue, name it something like portugal-flag-fix
  3. Open up assets/svg/1f1f5-1f1f9.svg with inkscape or adobe illustrator, or any program capable of editing svg images
  4. Correct the error. It looks like you could just make the top-right line a bit longer.
  5. Save it, and render a 72x72 png version into assets/72x72/1f1f5-1f1f9.png.
  6. Profit!

@VeeBack
Copy link
Author

VeeBack commented Jul 26, 2020

I tried opening it up in vectr, but it really didn't like that. Hence why I said I didn't know how to do it. PRs themselves I do know how to do 😃

I'll try the programs suggested tomorrow, thanks

conorhennessy added a commit to conorhennessy/twemoji that referenced this issue Jul 27, 2020
Closing the gap as outlined in issue twitter#414
conorhennessy added a commit to conorhennessy/twemoji that referenced this issue Jul 27, 2020
Re rendered the png to reflect changes to SVG - Closing the gap as outlined in issue twitter#414
@conorhennessy
Copy link

I see some comments were made over the weekend about this!
I don't mean to steal the task from @HVEVB but over the weekend, in fact, I fiddled with this and fixed it. I'll make a pull request now. 😄 🇵🇹

@HVEVB I can show you how to do it too and/or how to make a PR, if you wish, so you know how to contribute in the future? 🚀

@VeeBack
Copy link
Author

VeeBack commented Jul 27, 2020

I'm happy you fixed it 😉 I think I can figure out how to do it though, but thanks for the offer. I'll close the issue when the PR is merged

@jdecked
Copy link
Contributor

jdecked commented Mar 12, 2021

This has been fixed in v13.0.2.

@desrosj
Copy link

desrosj commented Mar 18, 2021

I was looking into exactly what had changed in the Emoji for v13.0.2 and noticed the SVG in the original report links to the primary branch, which now shows the corrected Emoji.

I just wanted to add a link to a previous version of the flag for anyone looking to see what the original issue was: https://raw.githubusercontent.com/twitter/twemoji/v12.1.6/assets/svg/1f1f5-1f1f9.svg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants