Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Guice to 5.0.1+ #559

Open
greggdonovan opened this issue Mar 24, 2021 · 5 comments
Open

Upgrade Guice to 5.0.1+ #559

greggdonovan opened this issue Mar 24, 2021 · 5 comments

Comments

@greggdonovan
Copy link

Is your feature request related to a problem? Please describe.

Finatra depends on Guice 4.2.x which depends on cglib which is no longer being developed and has not been updated to the new JDK9+ module system. See this Guice issue for more discussion.

Describe the solution you'd like

Upgrade Guice from 4.2.x to 5.0.1+.

Describe alternatives you've considered
With Guice 4.2.x's use of cglib, users need to add --add-opens java.base/java.lang=ALL-UNNAMED or something like it to their JVM startup options.

Additional context
N/A

@cacoco
Copy link
Contributor

cacoco commented Mar 24, 2021

@greggdonovan Thanks for the issue, please note that Finatra is still only targeted to work with JDK8 at the moment (and soon JDK11).

@greggdonovan
Copy link
Author

@cacoco Thanks! FWIW, we've been running Finatra for a year in production with JDK11 with no issues. This issue came up during testing of our JDK16 upgrade.

@cacoco
Copy link
Contributor

cacoco commented Mar 24, 2021

@greggdonovan that's great! Thanks again for the issue.

@redkhalil
Copy link

Any update on the timeline for next supported version of JDK?

@cacoco
Copy link
Contributor

cacoco commented Dec 26, 2021

@redkhalil we're targeting JDK11 support for Q1 or Q2 of 2022.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants