Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.62%. Comparing base (27f5d4d) to head (30c00ab).

@@            Coverage Diff             @@
##           master     #767      +/-   ##
==========================================
+ Coverage   92.56%   92.62%   +0.05%     
==========================================
  Files          47       47              
  Lines        8393     8393              
  Branches     1850     1850              
==========================================
+ Hits         7769     7774       +5     
+ Misses        359      356       -3     
+ Partials      265      263       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Releasing a new version of pydoctor @glyph @adiroiban.

Hi @tristanlatr I have pushed a change to publish the packagte using PyPI Trusted Publishers API

The PyPI changes were made here https://pypi.org/manage/project/pydoctor/settings/publishing/#errors

I think that only Twisted Organization admins have permissions to PyPI manager... but now, any package published from unit.yaml is accepted by PyPI.

Feel free to create a tag based on the latest commit from this PR.

It should trigger a PyPi package publishing.

Thanks

I have also removed the PYPI_TOKEN token from secrets as it should never be used again

I have removed the ubuntu 20.04 required jobs as it looks like it is no longer used.

Thanks a lot Adi, I’ll try again

Looks like it failed...

Error: Trusted publishing exchange failure: 
OpenID Connect token retrieval failed: GitHub: missing or insufficient OIDC token permissions, the ACTIONS_ID_TOKEN_REQUEST_TOKEN environment variable was unset

This generally indicates a workflow configuration error, such as insufficient
permissions. Make sure that your workflow has `id-token: write` configured
at the job level, e.g.:

``yaml
permissions:
  id-token: write
``

Learn more at https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/about-security-hardening-with-openid-connect#adding-permissions-settings.

Full log: https://github.com/twisted/pydoctor/actions/runs/9098901922/job/25010411600

@adiroiban

True. My bad.

I have added explicit job permissions.

You can delete the tag and create it again. It should re-trigger the job

Still not working @adiroiban

ERROR    HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/        
         Can't have direct dependency: twisted@                                 
         git+https://github.com/twisted/twisted.git ; extra == "mypy". See      
         https://packaging.python.org/specifications/core-metadata for more     
         information.  

The pypi publishing works.

The package was rejected due to setup.cfg deps definition

It looks like we need to do a release for Twisted.

Why do we need the latest Twisted here ?

I think we don’t need it anymore

According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅

According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅