Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active button in btn-group missing right border #8805

Closed
danasilver opened this issue Jul 29, 2013 · 3 comments
Closed

Active button in btn-group missing right border #8805

danasilver opened this issue Jul 29, 2013 · 3 comments
Labels
Milestone

Comments

@danasilver
Copy link

The right border of an active button is hidden under the next button to the right. The border appears when the active button has the :hover class and is the only thing that changes when the active button is hovered, making it somewhat conspicuous.

This can be seen in this Fiddle on the first button in the first btn-group and the second button in the second btn-group when each button is hovered.

Bootstrap 3.0.0 RC1

@mdo
Copy link
Member

mdo commented Jul 29, 2013

Works for me in the docs—just tried it out.

Your fiddle doesn't seem to apply to the problem you're describing though.

@danasilver
Copy link
Author

I didn't see any active buttons in button groups in the docs.

I didn't realize the fiddle url wasn't updated from the Bootstrap 3 skeleton. Here's the correct url: http://jsfiddle.net/KnuU6/4/

@danasilver
Copy link
Author

This seems to happen because z-index: 2 is only set on the hover and active pseudo classes in button-groups.less and not the active class that a button may have. Here's a fix that adds active as a class for which buttons in a btn-group have z-index: 2.

df9186c

Edit: Link to the issue in the docs: http://getbootstrap.com/javascript/#buttons. Under checkbox or radio, click on one of the left two buttons, mouse off, then hover over the active button.

@mdo mdo closed this as completed in d95ff9d Aug 5, 2013
stempler pushed a commit to stempler/bootstrap that referenced this issue Apr 11, 2014
stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants