Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper design for Space Pirates and "pseudo realms" #713

Closed
BottledByte opened this issue Dec 29, 2023 · 2 comments
Closed

Proper design for Space Pirates and "pseudo realms" #713

BottledByte opened this issue Dec 29, 2023 · 2 comments
Labels
Wait for verify Issue has been implemented but needs verification that it works.

Comments

@BottledByte
Copy link
Contributor

There are two SpaceRaces which are not real races, SPACE_PIRATE and SPACE_MONSTERS.
Those two pseudo races make SpaceRace more difficult to define and are negatively impacting generic code for handling races when they will be dehardcoded.

Both "races" are used primarily for "board players", which are not "real" realms.
Such "pseudo" realms need a proper system and not rely on the SpaceRace enum for their definition.

@BottledByte BottledByte changed the title Proper design for handling Space Pirates and "pseudo realms" Proper design for Space Pirates and "pseudo realms" Dec 29, 2023
@tuomount
Copy link
Owner

This decision was done, since I could use similar handling for those as any other realm including AI, how to get graphics etc. I was thinking when SpaceRace is proper class and not enum, these could created during star map creation based for example Human and just change the graphics, dialog and such. Then these pseudo races would not interference with other space races.

@tuomount tuomount added the Wait for verify Issue has been implemented but needs verification that it works. label May 1, 2024
@tuomount
Copy link
Owner

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Wait for verify Issue has been implemented but needs verification that it works.
Projects
None yet
Development

No branches or pull requests

2 participants