Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TabView makes some binds that are never saved #155

Open
Moosems opened this issue Apr 26, 2024 · 1 comment
Open

TabView makes some binds that are never saved #155

Moosems opened this issue Apr 26, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@Moosems
Copy link
Collaborator

Moosems commented Apr 26, 2024

Describe the bug

This means that they aren't cleaned up in .destroy() and is technically a memory leak. Lines 192, 199.

Expected behavior

We save them and destroy the binds in memory once they're no longer needed so we don't leak memory.

Operating system

Isn't in the list (describe below)

Extra details about your system

Not relevant

@Moosems Moosems added the good first issue Good for newcomers label Apr 26, 2024
@Moosems
Copy link
Collaborator Author

Moosems commented Apr 26, 2024

It calls self.binds which doesn't lead to anywhere from pyright and I think it calls here but that doesn't seem to save the bind either

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant