False positive "side effects" warning when using Swift Macros

[pepicrft]

What happened?

Users reported getting "static side effects" warnings that seem to be false positives in their projects. They happen when the project has Swift Macros; our logic doesn't account for that. We need to adjust the logic that checks for side effects to skip the traversal when it comes across a macro executable.

How do we reproduce it?

1. Create a project with an app that depends on 2 dynamic frameworks
2. Add a Swift Macros to each of those 2 dynamic frameworks
3. Generate the project

Error log

From a user:

Loading and constructing the graph
It might take a while if the cache is empty
Using cache binaries for the following targets: Dependencies, SwiftCompilerPlugin, SwiftSyntaxMacros, SwiftParser, ComposableArchitectureMacros, SwiftSyntaxMacroExpansion, SwiftSyntax510, SwiftParserDiagnostics, CombineSchedulers, SwiftSyntax509, SwiftCompilerPluginMessageHandling, CasePathsMacros, XCTestDynamicOverlay, SwiftUINavigationCore, SwiftBasicFormat, ComposableArchitecture, PerceptionMacros, OrderedCollections, SwiftSyntax, Clocks, DependenciesMacrosPlugin, SwiftSyntaxBuilder, DependenciesMacros, CustomDump, _CollectionsUtilities, Perception, SwiftOperators, SwiftDiagnostics, IdentifiedCollections, ConcurrencyExtras, CasePaths
Generating workspace Ratings.xcworkspace
Generating project Ratings
Project generated.
Total time taken: 0.464s

The following warnings need attention:
 · Xcframework 'DependenciesMacros.xcframework' has been linked from target 'AppFeature' and target 'HomeFeature', it is a static product so may introduce unwanted side effects.
 · Xcframework 'CustomDump.xcframework' has been linked from target 'AppFeature' and target 'HomeFeature', it is a static product so may introduce unwanted side effects.
 · Xcframework 'CustomDump.xcframework' has been linked from target 'AppFeature', target 'HomeFeature', and target 'Ratings', it is a static product so may introduce unwanted side effects.
 · Xcframework 'Perception.xcframework' has been linked from target 'AppFeature', target 'HomeFeature', and target 'Ratings', it is a static product so may introduce unwanted side effects.
 · Xcframework 'OrderedCollections.xcframework' has been linked from target 'AppFeature', target 'HomeFeature', and target 'Ratings', it is a static product so may introduce unwanted side effects.
 · Xcframework 'SwiftBasicFormat.xcframework' has been linked from target 'AppFeature', target 'HomeFeature', and target 'Ratings', it is a static product so may introduce unwanted side effects.
 · Xcframework 'Dependencies.xcframework' has been linked from target 'AppFeature', target 'HomeFeature', and target 'Ratings', it is a static product so may introduce unwanted side effects.
 · Xcframework 'SwiftOperators.xcframework' has been linked from target 'AppFeature' and target 'HomeFeature', it is a static product so may introduce unwanted side effects.
 · Xcframework 'CombineSchedulers.xcframework' has been linked from target 'AppFeature' and target 'HomeFeature', it is a static product so may introduce unwanted side effects.
 · Xcframework 'Clocks.xcframework' has been linked from target 'AppFeature', target 'HomeFeature', and target 'Ratings', it is a static product so may introduce unwanted side effects.
 · Xcframework 'SwiftSyntax509.xcframework' has been linked from target 'AppFeature', target 'HomeFeature', and target 'Ratings', it is a static product so may introduce unwanted side effects.
 · Xcframework 'SwiftSyntaxMacros.xcframework' has been linked from target 'AppFeature', target 'HomeFeature', and target 'Ratings', it is a static product so may introduce unwanted side effects.
 · Xcframework 'SwiftSyntax.xcframework' has been linked from target 'AppFeature', target 'HomeFeature', and target 'Ratings', it is a static product so may introduce unwanted side effects.
 · Xcframework 'CombineSchedulers.xcframework' has been linked from target 'AppFeature', target 'HomeFeature', and target 'Ratings', it is a static product so may introduce unwanted side effects.
 · Xcframework 'SwiftCompilerPlugin.xcframework' has been linked from target 'AppFeature', target 'HomeFeature', and target 'Ratings', it is a static product so may introduce unwanted side effects.
 · Xcframework 'XCTestDynamicOverlay.xcframework' has been linked from target 'AppFeature' and target 'HomeFeature', it is a static product so may introduce unwanted side effects.
 · Xcframework 'IdentifiedCollections.xcframework' has been linked from target 'AppFeature', target 'HomeFeature', and target 'Ratings', it is a static product so may introduce unwanted side effects.
 · Xcframework 'SwiftCompilerPlugin.xcframework' has been linked from target 'AppFeature' and target 'HomeFeature', it is a static product so may introduce unwanted side effects.
 · Xcframework 'SwiftParser.xcframework' has been linked from target 'AppFeature', target 'HomeFeature', and target 'Ratings', it is a static product so may introduce unwanted side effects.
 · Xcframework 'ConcurrencyExtras.xcframework' has been linked from target 'AppFeature', target 'HomeFeature', and target 'Ratings', it is a static product so may introduce unwanted side effects.
 · Xcframework 'IdentifiedCollections.xcframework' has been linked from target 'AppFeature' and target 'HomeFeature', it is a static product so may introduce unwanted side effects.
 · Xcframework 'SwiftSyntaxBuilder.xcframework' has been linked from target 'AppFeature', target 'HomeFeature', and target 'Ratings', it is a static product so may introduce unwanted side effects.
 · Xcframework 'SwiftParser.xcframework' has been linked from target 'AppFeature' and target 'HomeFeature', it is a static product so may introduce unwanted side effects.
 · Xcframework 'SwiftUINavigationCore.xcframework' has been linked from target 'AppFeature', target 'HomeFeature', and target 'Ratings', it is a static product so may introduce unwanted side effects.
 · Xcframework '_CollectionsUtilities.xcframework' has been linked from target 'AppFeature' and target 'HomeFeature', it is a static product so may introduce unwanted side effects.
 · Xcframework 'CasePaths.xcframework' has been linked from target 'AppFeature' and target 'HomeFeature', it is a static product so may introduce unwanted side effects.
 · Xcframework 'SwiftSyntax.xcframework' has been linked from target 'AppFeature' and target 'HomeFeature', it is a static product so may introduce unwanted side effects.
 · Xcframework 'DependenciesMacros.xcframework' has been linked from target 'AppFeature', target 'HomeFeature', and target 'Ratings', it is a static product so may introduce unwanted side effects.
 · Xcframework '_CollectionsUtilities.xcframework' has been linked from target 'AppFeature', target 'HomeFeature', and target 'Ratings', it is a static product so may introduce unwanted side effects.
 · Xcframework 'SwiftBasicFormat.xcframework' has been linked from target 'AppFeature' and target 'HomeFeature', it is a static product so may introduce unwanted side effects.
 · Xcframework 'CasePaths.xcframework' has been linked from target 'AppFeature', target 'HomeFeature', and target 'Ratings', it is a static product so may introduce unwanted side effects.
 · Xcframework 'SwiftOperators.xcframework' has been linked from target 'AppFeature', target 'HomeFeature', and target 'Ratings', it is a static product so may introduce unwanted side effects.
 · Xcframework 'SwiftSyntaxMacroExpansion.xcframework' has been linked from target 'AppFeature', target 'HomeFeature', and target 'Ratings', it is a static product so may introduce unwanted side effects.
 · Xcframework 'Clocks.xcframework' has been linked from target 'AppFeature' and target 'HomeFeature', it is a static product so may introduce unwanted side effects.
 · Xcframework 'SwiftParserDiagnostics.xcframework' has been linked from target 'AppFeature', target 'HomeFeature', and target 'Ratings', it is a static product so may introduce unwanted side effects.
 · Xcframework 'SwiftSyntax510.xcframework' has been linked from target 'AppFeature' and target 'HomeFeature', it is a static product so may introduce unwanted side effects.
 · Xcframework 'Perception.xcframework' has been linked from target 'AppFeature' and target 'HomeFeature', it is a static product so may introduce unwanted side effects.
 · Xcframework 'XCTestDynamicOverlay.xcframework' has been linked from target 'AppFeature', target 'HomeFeature', and target 'Ratings', it is a static product so may introduce unwanted side effects.
 · Xcframework 'OrderedCollections.xcframework' has been linked from target 'AppFeature' and target 'HomeFeature', it is a static product so may introduce unwanted side effects.
 · Xcframework 'SwiftSyntaxMacros.xcframework' has been linked from target 'AppFeature' and target 'HomeFeature', it is a static product so may introduce unwanted side effects.
 · Xcframework 'SwiftUINavigationCore.xcframework' has been linked from target 'AppFeature' and target 'HomeFeature', it is a static product so may introduce unwanted side effects.
 · Xcframework 'SwiftSyntaxBuilder.xcframework' has been linked from target 'AppFeature' and target 'HomeFeature', it is a static product so may introduce unwanted side effects.
 · Xcframework 'SwiftCompilerPluginMessageHandling.xcframework' has been linked from target 'AppFeature', target 'HomeFeature', and target 'Ratings', it is a static product so may introduce unwanted side effects.
 · Xcframework 'Dependencies.xcframework' has been linked from target 'AppFeature' and target 'HomeFeature', it is a static product so may introduce unwanted side effects.
 · Xcframework 'SwiftDiagnostics.xcframework' has been linked from target 'AppFeature' and target 'HomeFeature', it is a static product so may introduce unwanted side effects.
 · Xcframework 'SwiftSyntax509.xcframework' has been linked from target 'AppFeature' and target 'HomeFeature', it is a static product so may introduce unwanted side effects.
 · Xcframework 'SwiftSyntaxMacroExpansion.xcframework' has been linked from target 'AppFeature' and target 'HomeFeature', it is a static product so may introduce unwanted side effects.
 · Xcframework 'SwiftDiagnostics.xcframework' has been linked from target 'AppFeature', target 'HomeFeature', and target 'Ratings', it is a static product so may introduce unwanted side effects.
 · Xcframework 'ConcurrencyExtras.xcframework' has been linked from target 'AppFeature' and target 'HomeFeature', it is a static product so may introduce unwanted side effects.
 · Xcframework 'SwiftCompilerPluginMessageHandling.xcframework' has been linked from target 'AppFeature' and target 'HomeFeature', it is a static product so may introduce unwanted side effects.
 · Xcframework 'SwiftParserDiagnostics.xcframework' has been linked from target 'AppFeature' and target 'HomeFeature', it is a static product so may introduce unwanted side effects.
 · Xcframework 'SwiftSyntax510.xcframework' has been linked from target 'AppFeature', target 'HomeFeature', and target 'Ratings', it is a static product so may introduce unwanted side effects.