Replies: 1 comment 1 reply
-
Thanks for putting this together @spqw 👍 it's much appreciated!
Perhaps the option can remain optional in the manifests and the default
The options structure will likely grow over time to accommodate various options that need configuring. As long as they are optional / have defaults from a usage stand point it should hopefully retain source compatibility and any cases that don't need it don't need to specify it. I agree that perhaps eventually this may become overwhelming but we'd revisit the approach separately and that would be for all options rather than this specific one.
I didn't quite follow this one - how would this solve / workaround the flagged issue?
We'll probably need to expand on the documentation / comments of this option to clarify what it does and when to use it, as there is also
You mentioned the specification of those empty localisations cause some CI validation errors, can those be easily re-created using a simple fixture that we can exercise? this possibly can be the best test - but of course if it introduced a lot of unnecessary overhead to Tuist then probably a unit test for the generated project and expected regions may suffice. Thanks again! |
Beta Was this translation helpful? Give feedback.
-
Need/problem
Given a user project doesn't support "en" language but instead "en-GB" as default region
When user generates project with Tuist
Then the project has an unexpected empty localization "en"
This can break CI localization checks depending on the project configuration
Slack thread : https://tuistapp.slack.com/archives/C018QG7U7SN/p1666102947385499
Motivation
Tuist could let the user choose the default regions to be different than "en"
Detailed design
Add
defaultRegions: [String]?
parameter toProject.Option.options
:so that user can set the project default regions in the manifest:
Adapt the following files to reflect that change:
Drawbacks
Alternatives
Adoption strategy
How we teach this
Unresolved questions
Beta Was this translation helpful? Give feedback.
All reactions