Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted videos should be added to the ignore list #286

Closed
samdoshi opened this issue Jul 27, 2022 · 9 comments
Closed

Deleted videos should be added to the ignore list #286

samdoshi opened this issue Jul 27, 2022 · 9 comments
Labels
enhancement New feature or request

Comments

@samdoshi
Copy link

It would be nice if videos (from subscribed channels) that have been deleted don't show up again in the download queue. Perhaps they could be added to the ignore list automatically when they are deleted?

@bbilly1
Copy link
Member

bbilly1 commented Jul 30, 2022

Yeah, we had a short conversation before about that. I was a bit hesitant, if that happens automatically, you won't be able to download it again, until you go to the ignored list and delete it from there. So that could be confusing, as any ignored videos will skip without any warning even if you add it explicitly.

But maybe there is a way how this could be done, so that it's obvious? Maybe as part of the delete confirmation? When you click on Delete Video you get Delete, Delete and ignore and cancel?

@bbilly1 bbilly1 added the question Further information is requested label Jul 30, 2022
@samdoshi
Copy link
Author

samdoshi commented Aug 1, 2022

I think you've got four options:

  1. Always add it to the ignore list
  2. An option in the settings to "add deleted videos to the ignore list"
  3. Your suggestion "Delete, Delete and ignore and cancel"
  4. Similarly to your suggestion, when you click delete you get the options "Delete", "Cancel", but also a checkbox "Also add to ignore list". The state of the checkbox can be remembered between uses.

I think I would like the 2nd or 4th options.

I think with options 1 and 2, you just need to make sure that there is a message in the confirmation saying that the deleted video will be added to the ignore list as well, so that users know where to find it again.

@bbilly1 bbilly1 added enhancement New feature or request and removed question Further information is requested labels Aug 2, 2022
@Joshfindit
Copy link

I would like to suggest adding a flag to the video metadata so that that flag can be used to ignore/hide in the UI.

This is related, but I actually want to be able to view all videos I have that have been removed from YouTube (and check if there are any freshly removed videos)

Something like:removed = user_deleted|uploader_made_private|uploader_deleted

@cmuc24
Copy link

cmuc24 commented Dec 22, 2022

oh nice, looks like similar to my suggested blacklist feature last year
thumbs up for that 👍

@bbilly1 bbilly1 added help wanted Extra attention is needed good first issue Good for newcomers labels Mar 27, 2023
@SmartPhoneLover

This comment was marked as off-topic.

@bbilly1
Copy link
Member

bbilly1 commented May 12, 2023

please, let's stay on topic, this feature is about ignoring deleted videos from feature downloads. the approach here makes sense to me: #286 (comment)

somebody just needs to implement it.

@SmartPhoneLover

This comment was marked as off-topic.

@WillScott73
Copy link

I take it no one has implemented it then, having spent a few hours deleting downloads I don't want to keep, only to see them be downloaded again.

If TA had been written in C++, VB.Net, C# or Golang I'd have given it a go myself....

@bbilly1 bbilly1 added pending-release Fixed and pending release and removed help wanted Extra attention is needed good first issue Good for newcomers labels May 9, 2024
@bbilly1 bbilly1 removed the pending-release Fixed and pending release label May 22, 2024
@bbilly1
Copy link
Member

bbilly1 commented May 22, 2024

that's now shipped with v0.4.8, please update.

@bbilly1 bbilly1 closed this as completed May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants