Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tsugi needs to handle older config.php files that don't include pre_config.php more gracefully #137

Open
csev opened this issue Nov 12, 2021 · 0 comments

Comments

@csev
Copy link
Collaborator

csev commented Nov 12, 2021

In early 2021 as we got rid of Silex, a new line was added to config.php that was required to be included before loading the autoloader.

require_once $dirroot."/vendor/tsugi/lib/include/pre_config.php";

This was announced on the dev list - but if someone does an upgrade and forgets this - they just seen an error later. Add some code to setup.php to notice when the config.php did not properly include pre_config.php.

Details from Tom Brierley:

I narrowed tsugi@85e055f to vendor/tsugi/lib, which bisects to tsugi-php@82dc98a moving _m() from setup.php into setup_i18n.php, which is not included in config.php. This is fixed in a series of commits ending in tsugi@16f5b01 by indirectly including it in pre_config.php

It looks like this line was added to config-dist.php in e9fd767 in January:
require_once $dirroot."/vendor/tsugi/lib/include/pre_config.php";
Which was missing from my config.php which I copied from dist last year.

Apologies if I've missed some instructions, I'm still fairly new to Tsugi and have only been running a dev server since last year.

Can I ask, is there a mechanism or an intended process for users to keep their config.php up to date with these types of changes? e.g are there some release/upgrade notes I should be reviewing, or is it possible this was taken care of by admin/upgrade.php and I should be stepping through each git tag?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant