Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database refactoring #113

Open
Timtam opened this issue Oct 23, 2017 · 1 comment
Open

database refactoring #113

Timtam opened this issue Oct 23, 2017 · 1 comment

Comments

@Timtam
Copy link
Collaborator

Timtam commented Oct 23, 2017

We do have separate databases for each language right now. This results in the following:

  • german players can only lookup german card names
  • when building a deck, you can only add in german cards, even if we already got more cards in english which just aren't translated yet
  • same goes for any other language besides english

I'd like to rework the database interface to have one database which attaches any other language file and merges all the tables into one large table which contains a language column or something, so we can grab for english/spanish/whatever card names from whatever ingame language we like.

@Timtam
Copy link
Collaborator Author

Timtam commented Nov 5, 2020

i'd be happy with adding a lookup fallback to english whenever you try to look up a card in your non-english language, but the card could not be found. That would allow to always look up english cards even when not currently playing with english english set as your main language.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant