Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could we check for config-dev presence in index.php? #1409

Open
Luke1982 opened this issue Nov 8, 2022 · 2 comments
Open

Could we check for config-dev presence in index.php? #1409

Luke1982 opened this issue Nov 8, 2022 · 2 comments

Comments

@Luke1982
Copy link
Contributor

Luke1982 commented Nov 8, 2022

Before this line:

if (!isset($dbconfig['db_hostname']) || $dbconfig['db_status'] == '_DB_STAT_') {

I would like to add:

if (is_file('config-dev.inc.php')) {
	require_once 'config-dev.inc.php';
}

to make development easier. Would that interfere with the program somewhere else?

@joebordes
Copy link
Contributor

Why is this necessary? We have that at the end of the config.inc.php file, where it must be captured always.

https://github.com/tsolucio/corebos/blob/master/config.template.php#L125

maybe you have to update your config.inc.php file?

@Luke1982
Copy link
Contributor Author

Luke1982 commented Nov 8, 2022

I'm trying to develop on a local machine, in my git repo. Right now, I have to develop in a local install, and when finished copy over all the changes to the git repo. I want to work directly in the git repo. Now maybe I could perform an installation in my git repo, but then I need to make sure I don't commit any changes made by the installation process. And I would like to just commit by performing a git add . without having to manually work through the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants