Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Press Enter to Reconnect" is not appropriate when using --once #1016

Open
DannyBen opened this issue Nov 6, 2022 · 1 comment
Open

"Press Enter to Reconnect" is not appropriate when using --once #1016

DannyBen opened this issue Nov 6, 2022 · 1 comment
Labels

Comments

@DannyBen
Copy link

DannyBen commented Nov 6, 2022

Describe the bug

In previous versions, the message that appears on exit made more sense. It used to be "Connection Closed" - which was more appropriate for my use cases.

I think it should be reverted to this message, if not for all cases, at least when running with --once.

To Reproduce

  1. Run ttyd --once --port 3000 --readonly echo PONG
  2. Open the browser at http://localhost:3000
  3. See PONG followed by "Press Enter to Reconnect"

Expected behavior

See "Connection Closed" as the exit message.

Environment:

  • OS: Ubuntu 20.04 LTS
  • Browser: Chrome
@DannyBen DannyBen added the bug label Nov 6, 2022
@DannyBen DannyBen changed the title "Press Enter to Reconnect" is not the right message when using --once "Press Enter to Reconnect" is not appropriate when using --once Nov 6, 2022
@tsl0922
Copy link
Owner

tsl0922 commented Feb 22, 2023

Thanks, will change the message for --once for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants