Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not support BTC Taproot address or SegWit address? #3821

Open
Sunshineyg00 opened this issue Apr 29, 2024 · 2 comments
Open

Not support BTC Taproot address or SegWit address? #3821

Sunshineyg00 opened this issue Apr 29, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Sunshineyg00
Copy link

Sunshineyg00 commented Apr 29, 2024

Describe the bug
When using TWBitcoinAddressIsValidString to verify a correct BTC Taproot address or a SegWit address, the return result is NO, which should be right.

To Reproduce
Steps to reproduce the behavior:

  1. use the latest version TrustWalletCore (4.0.40)
  2. try to verify a BTC Taproot address and a SegWit address:
    NSLog(@"--== btc: %d", TWBitcoinAddressIsValidString(TWStringCreateWithUTF8Bytes(@"bc1qar0srrr7xfkvy5l643lydnw9re59gtzzwf5mdq".UTF8String)));
    NSLog(@"--== btc: %d", TWBitcoinAddressIsValidString(TWStringCreateWithUTF8Bytes(@"bc1p5d7rjq7g6rdk2yhzks9smlaqtedr4dekq08ge8ztwac72sfr9rusxg3297".UTF8String)));
  3. the results are both "NO"

Expected behavior
The results are both "YES" as these are valid addresses.

@Sunshineyg00 Sunshineyg00 added the bug Something isn't working label Apr 29, 2024
@Sunshineyg00 Sunshineyg00 changed the title Not support BTCTaproot address or SegWit address? Not support BTC Taproot address or SegWit address? Apr 29, 2024
@satoshiotomakan
Copy link
Collaborator

Hi @Sunshineyg00, we're already working on this, thank you for noticing

@Sunshineyg00
Copy link
Author

Hi @Sunshineyg00, we're already working on this, thank you for noticing

Thank you for your reply and your tremendous effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants