Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KeyStore] Kotlin equivalent #2511

Open
1 of 2 tasks
hewigovens opened this issue Aug 18, 2022 · 2 comments
Open
1 of 2 tasks

[KeyStore] Kotlin equivalent #2511

hewigovens opened this issue Aug 18, 2022 · 2 comments
Labels
enhancement New feature or request priority:medium size:medium

Comments

@hewigovens
Copy link
Contributor

hewigovens commented Aug 18, 2022 •
edited

We have Swift KeyStore helper to access TWStoredKey easily; in order to support it on Web (local storage etc), it would be nice to have Typescript KeyStore

This is also a good chance to refactor and define generic KeyStore interfaces

  • Typescript
  • Kotlin
@hewigovens hewigovens changed the title [Wasm] Typescript KeyStore equivalent [KeyStore] Typescript / Kotlin equivalent Aug 18, 2022
@Milerius
Copy link
Collaborator

Milerius commented Aug 21, 2022 •
edited

We have Swift KeyStore helper to access TWStoredKey easily; in order to support it on Web (local storage etc), it would be nice to have Typescript KeyStore

This is also a good chance to refactor and define generic KeyStore interfaces

Full implementation of indexed_db manipulation in wasm/rust: https://github.com/KomodoPlatform/atomicDEX-API/tree/dev/mm2src/mm2_db/src/indexed_db

Simple local storage wasm manipulation in go: https://github.com/Milerius/mm2-client/blob/8ebc6c99fb54080220b114f1e120d965b43c2ac0/config/wasm_storage/wasm_storage.go

@hewigovens
Copy link
Contributor Author

hewigovens commented Aug 31, 2022 •
edited

Swift KeyStore:

  • KeyStore.swift inits with keyDirectory , manage multiple Wallet and one Watch (watches.json)
  • native DerivationPath struct -> expose cpp DerivationPath
  • native KeyStore.Error
  • helper export method, return private key or mnemonic -> could be moved to cpp
  • Wallet has identifier and StoredKey, native enum WalletType

@hewigovens hewigovens mentioned this issue Sep 6, 2022
Merged
6 tasks
@hewigovens hewigovens removed their assignment Sep 20, 2022
@hewigovens hewigovens changed the title [KeyStore] Typescript / Kotlin equivalent [KeyStore] Kotlin equivalent Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request priority:medium size:medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hewigovens @Milerius and others