Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribution/release [for ARM]: Update libobjc2 to version 2.1.1 as soon as published [title updated] #329

Open
Letterus opened this issue Aug 16, 2020 · 16 comments

Comments

@Letterus
Copy link

libobjc2 2.0 will not build for Linux ARM (armhf/arm64) until gnustep/libobjc2@4cf4ad1, see gnustep/libobjc2#164.

Please include that version for the next release. This is especially relevant for Debian Packaging when it comes to Raspbian, @pgeorgi.

@trunkmaster
Copy link
Owner

@Letterus thanks for info. I think it should be better to wait for new libobjc2 release.

@Letterus
Copy link
Author

Letterus commented Aug 23, 2020

@trunkmaster There now is a new release of libobjc2, v2.1.

https://github.com/gnustep/libobjc2/releases/tag/v2.1

That release provides serious improvements for the ARM platform.

Would be great if you could update that dependency. Please take into account that libobjc2 now depends on submodules, so you either have to init those via git or load the dependencies as tarballs (see release notes).

@Letterus Letterus changed the title Distribution/packaging for ARM: Update libobjc2 2.0 to git 4cf4ad1 Distribution/packaging for ARM: Update libobjc2 to version 2.1 [title updated] Aug 23, 2020
@trunkmaster
Copy link
Owner

@Letterus thanks, I'll update dependencies after some testing of new libobjc2 version.

@trunkmaster trunkmaster added this to the Release 1.0 milestone Aug 24, 2020
trunkmaster added a commit that referenced this issue Aug 27, 2020
@trunkmaster
Copy link
Owner

@Letterus I've updated SPEC file to a new release. Check it out.

@Letterus
Copy link
Author

Great, thank you!

@pgeorgi Would you mind adopting this update for the Debian packaging? That would be nice.

@pgeorgi
Copy link

pgeorgi commented Aug 30, 2020

@Letterus See #338

@Letterus
Copy link
Author

@Letterus See #338

Arr. Great, really happy about that. Trying again to apply that on ARM soon. Thank you!

(Thank you for the documentation as well. I'm going to try to learn how this Debian packaging works. It works great on my system, so it must be great, but I did not really get it yet. ;-))

@trunkmaster
Copy link
Owner

@Letterus has this issue resolved?

@Letterus
Copy link
Author

Letterus commented Sep 15, 2020

To be true: Not completely. It appeared that libobjc2 2.1 contains bug gnustep/libobjc2#177 which was only fixed after the release of 2.1. For the Debian build this is currently fixed by a patch, but it might be that for the next release you will need to rely on the release of 2.1.1.

@trunkmaster
Copy link
Owner

@Letterus current libobjc2 2.1 builds successfully on x86_64. Is it true for ARM? If answer is "yes", switch to version 2.1.1 or 2.2 should be a separate issue. If - "no" please reopen the issue and change title and description.

@Letterus Letterus changed the title Distribution/packaging for ARM: Update libobjc2 to version 2.1 [title updated] Distribution/release [for ARM]: Update libobjc2 to version 2.1.1 as soon as published [title updated] Sep 16, 2020
@Letterus
Copy link
Author

@trunkmaster This applied for a VM on x86_64. So I expect you to run into build issues at some time at the same point as well. I think this should be reopened and release 1.0 should contain libobjc2 2.1.1 or 2.2.

@Letterus
Copy link
Author

Please note that building libobjc2 (throwing a warning though) worked well, but linking against libobjc2 of subsequent builds failed at the point mentioned.

@trunkmaster
Copy link
Owner

trunkmaster commented Sep 16, 2020

@Letterus to make things clearer to me:

  1. Current libobjc2 2.1 has not described issue (warnings) during compilation niether on x86_64 nor on ARM. Is it a correct?
  2. libobjc2 development master branch has issue and hopefully will be fixed in upcoming new release. Correct?

If answers to both questions is "yes" - titled problem is potential issue on libobjc2 version upgrade. Am I right?

@Letterus
Copy link
Author

Letterus commented Sep 16, 2020

@Letterus to make things clearer to me:

@trunkmaster It's even more complicated:

1. Current libobjc2 2.1 has not described issue (warnings) during compilation niether on x86_64 nor on ARM. Is it a correct?

The bug existed as part of the 2.1 release tarball and was fixed within the 2.1 release tag. It should be fixed with a new 2.1.1 release tarball (or just use the git tag). I expect that issue to affect amd64 as well as ARM.

2. libobjc2 development `master` branch has issue and hopefully will be fixed in upcoming new release. Correct?

No. It's already fixed in master as of gnustep/libobjc2@365e536.

If answers to both questions is "yes" - titled problem is potential issue on libobjc2 version upgrade. Am I right?

No. ;-) You will need to upgrade or to use the 2.1 git tag to avoid the bug introduced with the 2.1 tarball.

@trunkmaster
Copy link
Owner

@Letterus great. Thank you for explanations. Reopening issue.

@trunkmaster trunkmaster reopened this Sep 16, 2020
@trunkmaster trunkmaster removed the fixed label Sep 16, 2020
@trunkmaster
Copy link
Owner

@Letterus Good news: https://github.com/gnustep/libobjc2/releases/tag/v2.2. I'll plan to change Packaging/Sources scripts first to test new release of libobjc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants