Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entire subtitles are shown in the first few seconds for some videos #176

Open
the-blank-x opened this issue Jun 19, 2023 · 4 comments
Open

Comments

@the-blank-x
Copy link

Expected behavior: Subtitles to be readable throughout the entire video

Actual behavior: The entire subtitles are shown in the first few seconds, without any more for the rest of the video

Steps to reproduce: Run pipe-viewer https://www.youtube.com/watch?v=_FCZnrUq3N4

Screenshot:

Additional details:
Config: pipe-viewer.conf.gz
The mangled subtitles of videos affected by this bug I've seen: affected-subs.tar.gz

If I set a breakpoint in GetCaption.pm:221 and run p $xml, I get the following output: _FCZnrUq3N4.xml.gz
I've figured out the cause by looking at yt-dlp's source code. If you're fine with that, then open the following section:

In GetCaption.pm:221, if I get $url, remove the tlang parameter, and fetch the URL with wget, the output looks fine. Additional links:
@the-blank-x
Copy link
Author

Given that there's a commit that uses code from yt-dlp, I'm assuming that using information from yt-dlp to fix this bug is fine? If so, let me know so that I can take a jab at this

@trizen
Copy link
Owner

trizen commented Jun 19, 2023

As far as I know, it's an YouTube issue.

@the-blank-x
Copy link
Author

the-blank-x commented Jun 19, 2023 via email

@trizen
Copy link
Owner

trizen commented Jun 19, 2023

The subtitle is offered by YouTube on (at least) 3 different formats. Probably only the format pipe-viewer uses is affected. If true, then switching to a different format would fix the issue.

Edit: the issue occurs when tlang=LANG parameter is used, which we use to auto-translate subtitles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants