Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restart does not work with TreeMesh + AMR + MPI #1912

Open
benegee opened this issue Apr 23, 2024 · 0 comments · May be fixed by #1913
Open

Restart does not work with TreeMesh + AMR + MPI #1912

benegee opened this issue Apr 23, 2024 · 0 comments · May be fixed by #1913
Labels
bug Something isn't working

Comments

@benegee
Copy link
Contributor

benegee commented Apr 23, 2024

Extend examples/tree_2d_dgsem/elixir_advection_extended.jl by an AMR callback like

amr_controller = ControllerThreeLevel(semi, IndicatorMax(semi, variable = first),
                                      base_level = 0,
                                      med_level = 1, med_threshold = 0.8,
                                      max_level = 2, max_threshold = 1.2)
amr_callback = AMRCallback(semi, amr_controller,
                           interval = 5,
                           adapt_initial_condition = false,
                           adapt_initial_condition_only_refine = true)

(possibly also tspan and intervals have to be changed to make sure the expected restart file is indeed written)

Then execute examples/tree_2d_dgsem/elixir_advection_restart.jl in parallel, e.g. via

 ~/bin/mpiexecjl -n 2 julia --project=. -e 'using Trixi;  trixi_include("../examples/tree_2d_dgsem/elixir_advection_restart.jl")'

The following error occurs:

ERROR: LoadError: AssertionError: New length would exceed capacity
Stacktrace:
  [1] insert!(c::Trixi.ParallelTree{2}, position::Int64, count::Int64)
    @ Trixi ~/trixi/Trixi.jl/src/auxiliary/containers.jl:187
  [2] refine_unbalanced!(t::Trixi.ParallelTree{2}, cell_ids::Vector{Int64}, sorted_unique_cell_ids::Vector{Int64})
    @ Trixi ~/trixi/Trixi.jl/src/meshes/abstract_tree.jl:327

This happens because load_mesh_parallel does not read the capacity attribute and instead sets capacity to the number of actual cells (n_cells_max is set to 0 by default)
@benegee benegee linked a pull request Apr 23, 2024 that will close this issue
Open
@DanielDoehring DanielDoehring added the bug Something isn't working label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Read in capacity for parallel TreeMesh trixi-framework/Trixi.jl
2 participants
@DanielDoehring @benegee