Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

objectForMapping not called #546

Closed
maksTheAwesome opened this issue Aug 12, 2016 · 4 comments
Closed

objectForMapping not called #546

maksTheAwesome opened this issue Aug 12, 2016 · 4 comments

Comments

@maksTheAwesome
Copy link

maksTheAwesome commented Aug 12, 2016

Hello guys.

I've updated pods (ObjectMapper (1.4.0)) a moment ago and had found out that func objectForMapping(map: Map) not called anymore when I call ParsingService<NSManagedObjectInheritant>().parseObject(Object).

It causes objects being duplicated. Please advise if I should use other function now.

UPD: Installed version 1.3. It works fine.

@jpstern
Copy link

jpstern commented Aug 12, 2016

objectForMapping(map: Map) was moved into
protocol StaticMappable: Mappable {
...
}

Replace Mappable with StaticMappable wherever you need to use objectForMapping

@tristanhimmelman
Copy link
Owner

Thanks @jpstern

@jakecraige
Copy link

I also ran into this recently and it took some time to debug.

I would have much preferred this to come with a version 2.0 ObjectMapper since this was a breaking change. Is there a particular reason it wasn't?

@tristanhimmelman
Copy link
Owner

@jakecraige my mistake, this change definitely warranted a major version number change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants